From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 115037 invoked by alias); 3 Apr 2015 14:41:16 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 115025 invoked by uid 89); 3 Apr 2015 14:41:15 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.6 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Fri, 03 Apr 2015 14:41:15 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t33EfD8K022505 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Fri, 3 Apr 2015 10:41:13 -0400 Received: from [10.10.116.19] ([10.10.116.19]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t33EfBa2006378; Fri, 3 Apr 2015 10:41:12 -0400 Message-ID: <551EA684.8090600@redhat.com> Date: Fri, 03 Apr 2015 14:41:00 -0000 From: Jason Merrill User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Aldy Hernandez CC: gcc-patches Subject: Re: [debug-early] equate new DIE with DW_AT_specificationto a previous declaration References: <5508874D.70008@redhat.com> <5508DF27.9060607@redhat.com> <55099EEB.70402@redhat.com> In-Reply-To: <55099EEB.70402@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2015-04/txt/msg00122.txt.bz2 On 03/18/2015 11:51 AM, Aldy Hernandez wrote: > On 03/17/2015 07:12 PM, Jason Merrill wrote: >> Why are we outlining a DECL_EXTERNAL function? > > SRA has no restrictions on whether a function is DECL_EXTERNAL. Aha. So it seems that DECL_EXTERNAL is the wrong gate for equate_decl_number_to_die here. I think the rule we want is that if we don't already have a non-declaration DIE for a function, we should equate the new DIE. Let's remove the existing calls and replace them with a single conditional call before the if (declaration). Incidentally, > /* A declaration that has been previously dumped needs no > additional information. */ > if (dumped_early && declaration) > return; Do we need to check dumped_early here? I would think that any declaration that has an old_die needs no additional information. Jason