From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 81257 invoked by alias); 8 Apr 2015 11:25:43 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 81165 invoked by uid 89); 8 Apr 2015 11:25:42 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.4 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.2 X-HELO: mo4-p00-ob.smtp.rzone.de Received: from mo4-p00-ob.smtp.rzone.de (HELO mo4-p00-ob.smtp.rzone.de) (81.169.146.217) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Wed, 08 Apr 2015 11:25:41 +0000 X-RZG-AUTH: :LXoWVUeid/7A29J/hMvvT3ol15ykJcYwTPbBBR62PQx1xqvTHw== X-RZG-CLASS-ID: mo00 Received: from [192.168.0.22] (ip5b43a95f.dynamic.kabel-deutschland.de [91.67.169.95]) by smtp.strato.de (RZmta 37.5 DYNA|AUTH) with ESMTPSA id n024e0r38BPaCaD (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA (curve secp521r1 with 521 ECDH bits, eq. 15360 bits RSA)) (Client did not present a certificate); Wed, 8 Apr 2015 13:25:36 +0200 (CEST) Message-ID: <55251030.1070305@gjlay.de> Date: Wed, 08 Apr 2015 11:25:00 -0000 From: Georg-Johann Lay User-Agent: Mozilla/5.0 (X11; Linux i686; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: Denis Chertykov CC: "Sivanupandi, Pitchumani" , GCC Patches , Joerg Wunsch , "Selvaraj, Senthil_Kumar" Subject: Re: [patch,avr]: Part2: Fix various problems with specs and specs file generation. References: <54F4BCA1.7080707@gjlay.de> <20150303132144.GC24277@atmel.com> <54FDC417.1000008@gjlay.de> <5523CEDE.1060204@gjlay.de> In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2015-04/txt/msg00302.txt.bz2 Am 04/08/2015 um 10:28 AM schrieb Denis Chertykov: > 2015-04-07 15:34 GMT+03:00 Georg-Johann Lay : >> Am 04/06/2015 um 11:54 AM schrieb Sivanupandi, Pitchumani: >>> >>> Hi Johann, >>> >>> Did you try running g++ tests? >>> It seems xgcc is invoked to get multilibs (from gcc/testsuite/lib/g++.exp) >>> which failed to find specs file. >> >> >> >> This is because libgloss.exp:get_multilibs (used from g++_init) runs xgcc >> ($compiler) without -B, i.e. without any prefix. Without prefix there is no >> way to determine where the specs files are located. >> >> Patching driver_self_specs to read a specs file by means of -specs= is, >> well, not very common. I don't know any other target which does that. >> >> As a work-around you can run the tests against the installed compiler. >> >> Denis, what do you think? I could add yet another fixme to avr backend like >> the following; that way there's no need to change dejagnu: >> >> >> Johann >> >> Index: config/avr/driver-avr.c >> =================================================================== >> --- config/avr/driver-avr.c (revision 221602) >> +++ config/avr/driver-avr.c (working copy) >> @@ -80,6 +80,20 @@ avr_devicespecs_file (int argc, const ch >> return X_NODEVLIB; >> >> case 1: >> + if (0 == strcmp ("device-specs", argv[0])) >> + { >> + /* FIXME: This means "device-specs%s" from >> avr.h:DRIVER_SELF_SPECS >> + has not been resolved to a path. That case can occur when the >> + c++ testsuite is run from the build directory. DejaGNU's >> + libgloss.exp:get_multilibs runs $compiler without -B, i.e.runs >> + xgcc without specifying a prefix. Without any prefix, there >> is >> + no means to find out where the specs files might be located. >> + get_multilibs runs xgcc --print-multi-lib, hence we don't >> + actually need information form a specs file and may skip it >> + altogether. */ >> + return X_NODEVLIB; >> + } >> + >> mmcu = AVR_MMCU_DEFAULT; >> break; >> > > I'm weak in dejagnu internals and c++ testsuite. > It looks like an acceptable solution. > > Denis. Pitchumani, does that patch work for you? If so I'd go ahead and apply it. And what about the spaces problem as mentioned in http://savannah.nongnu.org/bugs/?44574 http://lists.gnu.org/archive/html/avr-libc-dev/2015-03/msg00010.html Art there plans to fix that? Johann