From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 50408 invoked by alias); 9 Apr 2015 21:16:54 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 50389 invoked by uid 89); 9 Apr 2015 21:16:53 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Thu, 09 Apr 2015 21:16:52 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t39LGoRD006038 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Thu, 9 Apr 2015 17:16:50 -0400 Received: from [10.10.52.246] (unused [10.10.52.246] (may be forged)) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t39LGmiJ026623 for ; Thu, 9 Apr 2015 17:16:50 -0400 Message-ID: <5526EC40.8040000@redhat.com> Date: Thu, 09 Apr 2015 21:16:00 -0000 From: Martin Sebor User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: Gcc Patch List Subject: Re: [PATCH] gfortran.dg/pr32627.f03 prints nul byte References: <5526CAF9.8080907@redhat.com> In-Reply-To: <5526CAF9.8080907@redhat.com> Content-Type: multipart/mixed; boundary="------------060505010700080203060401" X-IsSubscribed: yes X-SW-Source: 2015-04/txt/msg00416.txt.bz2 This is a multi-part message in MIME format. --------------060505010700080203060401 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-length: 1213 Attached is an updated patch that fixes the substr_6.f90 test that also prints a nul character to stdout. I don't think there are any others. Besides interfering with the debugging of the log corruption I mentioned, printing nuls or control characters in tests is also problematic for tools designed to post-process log files (e.g., grep) that are intended to work with text files (i.e., files not containing nuls). Control characters can cause the tools to fail in non-C locales (such as UTF-8). On 04/09/2015 12:54 PM, Martin Sebor wrote: > We've been debugging a problem where nul (and other control) > characters have been randomly appearing in powerpc parallel > build logs. In the process, I noticed that some of the nuls > are readily reproducible. One such case is due to > the pr32627.f03 test which verifies that Fortran programs > can initialize character arrays from C strings. The test > declares an array as big as the C string (including the > terminating nul) and prints its value to stdout. This then > causes the nul to appear in the log files. > > The attached patch changes the declaration of the Fortran > array to match the number of non-nul characters. Tested on > powerpc64. > > Martin --------------060505010700080203060401 Content-Type: text/x-patch; name="gcc-fortran-nul.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="gcc-fortran-nul.patch" Content-length: 1270 2015-04-09 Martin Sebor * gfortran.dg/pr32627.f03 (strptr): Change size to match the number of non-nul characters. * gfortran.dg/substr_6.f90: Make the NUL character visible on stdout and avoid corrupting text output. diff --git a/gcc/testsuite/gfortran.dg/pr32627.f03 b/gcc/testsuite/gfortran.dg/pr32627.f03 index f8695e0..d9e2b13 100644 --- a/gcc/testsuite/gfortran.dg/pr32627.f03 +++ b/gcc/testsuite/gfortran.dg/pr32627.f03 @@ -18,7 +18,7 @@ program main type( c_ptr ) :: x type( A ), pointer :: fptr type( A ), target :: my_a_type - character( len=9 ), pointer :: strptr + character( len=8 ), pointer :: strptr fptr => my_a_type diff --git a/gcc/testsuite/gfortran.dg/substr_6.f90 b/gcc/testsuite/gfortran.dg/substr_6.f90 index 813a025..a7cdc10 100644 --- a/gcc/testsuite/gfortran.dg/substr_6.f90 +++ b/gcc/testsuite/gfortran.dg/substr_6.f90 @@ -11,6 +11,15 @@ if (c(1) /= " ") call abort() c = (/ c0(1)(1:5) /) do i=1,5 if (c(1)(i:i) /= c1(i)) call abort() + + ! Make NULs visible (and avoid corrupting text output). + if (c(1)(i:i) == ACHAR(0)) then + print "(a,$)", "" + else + print "(a,$)", c(1)(i:i) + end if end do -print *, c(1) + +print *, "" + end --------------060505010700080203060401--