* [PATCH] PR target/47098 OBSD_LIB_SPEC on i686-openbsd3 missing
@ 2015-04-11 22:15 Bernhard Reutner-Fischer
2015-04-13 13:08 ` Jeff Law
0 siblings, 1 reply; 3+ messages in thread
From: Bernhard Reutner-Fischer @ 2015-04-11 22:15 UTC (permalink / raw)
To: gcc-patches; +Cc: Bernhard Reutner-Fischer, Jakub Jelinek
gcc/config/openbsd.h:143:18: error: âOBSD_LIB_SPECâ was not declared in
this scope
#define LIB_SPEC OBSD_LIB_SPEC
^
gcc/gcc.c:879:31: note:
in expansion of macro âLIB_SPECâ
static const char *lib_spec = LIB_SPEC;
^
make[2]: *** [gcc.o] Error 1
Is the patch below ok for trunk?
i.e. openbsd-oldgas.h is only used on
i?86-*-openbsd2.*|i?86-*openbsd3.[0123] so is right on spot it seems.
Alternatively remove openbsd <= 3.3 support altogether since openbsd-3.3 was
released May 1, 2003.
This probably needs a deprecation announcement from Release Managers or
something.
gcc/ChangeLog:
2015-04-10 Bernhard Reutner-Fischer <aldot@gcc.gnu.org>
PR target/47098
* config/openbsd-oldgas.h (OBSD_LIB_SPEC): Add.
---
gcc/config/openbsd-oldgas.h | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/gcc/config/openbsd-oldgas.h b/gcc/config/openbsd-oldgas.h
index 04a4d37..5cef1eb 100644
--- a/gcc/config/openbsd-oldgas.h
+++ b/gcc/config/openbsd-oldgas.h
@@ -20,3 +20,7 @@ along with GCC; see the file COPYING3. If not see
#define OBSD_OLD_GAS
+
+/* OpenBSD3.0 had no libpthread, pthreads lived in -lc_r */
+#define OBSD_LIB_SPEC "%{!shared:-lc%{pthread:_r}}"
+
--
1.7.10.4
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] PR target/47098 OBSD_LIB_SPEC on i686-openbsd3 missing
2015-04-11 22:15 [PATCH] PR target/47098 OBSD_LIB_SPEC on i686-openbsd3 missing Bernhard Reutner-Fischer
@ 2015-04-13 13:08 ` Jeff Law
2015-04-22 8:42 ` Bernhard Reutner-Fischer
0 siblings, 1 reply; 3+ messages in thread
From: Jeff Law @ 2015-04-13 13:08 UTC (permalink / raw)
To: Bernhard Reutner-Fischer, gcc-patches; +Cc: Jakub Jelinek
On 04/11/2015 04:15 PM, Bernhard Reutner-Fischer wrote:
> gcc/config/openbsd.h:143:18: error: âOBSD_LIB_SPECâ was not declared in
> this scope
> #define LIB_SPEC OBSD_LIB_SPEC
> ^
> gcc/gcc.c:879:31: note:
> in expansion of macro âLIB_SPECâ
> static const char *lib_spec = LIB_SPEC;
> ^
> make[2]: *** [gcc.o] Error 1
>
> Is the patch below ok for trunk?
>
> i.e. openbsd-oldgas.h is only used on
> i?86-*-openbsd2.*|i?86-*openbsd3.[0123] so is right on spot it seems.
>
> Alternatively remove openbsd <= 3.3 support altogether since openbsd-3.3 was
> released May 1, 2003.
> This probably needs a deprecation announcement from Release Managers or
> something.
>
> gcc/ChangeLog:
>
> 2015-04-10 Bernhard Reutner-Fischer <aldot@gcc.gnu.org>
>
> PR target/47098
> * config/openbsd-oldgas.h (OBSD_LIB_SPEC): Add.
OK.
If you want to deprecate the ancient openbsd support, that can be a
follow-up.
Jeff
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] PR target/47098 OBSD_LIB_SPEC on i686-openbsd3 missing
2015-04-13 13:08 ` Jeff Law
@ 2015-04-22 8:42 ` Bernhard Reutner-Fischer
0 siblings, 0 replies; 3+ messages in thread
From: Bernhard Reutner-Fischer @ 2015-04-22 8:42 UTC (permalink / raw)
To: Jeff Law; +Cc: GCC Patches, Jakub Jelinek
On 13 April 2015 at 15:08, Jeff Law <law@redhat.com> wrote:
> On 04/11/2015 04:15 PM, Bernhard Reutner-Fischer wrote:
>>
>> gcc/config/openbsd.h:143:18: error: ‘OBSD_LIB_SPEC’ was not declared in
>> this scope
>> #define LIB_SPEC OBSD_LIB_SPEC
>> ^
>> gcc/gcc.c:879:31: note:
>> in expansion of macro ‘LIB_SPEC’
>> static const char *lib_spec = LIB_SPEC;
>> ^
>> make[2]: *** [gcc.o] Error 1
>>
>> Is the patch below ok for trunk?
>>
>> i.e. openbsd-oldgas.h is only used on
>> i?86-*-openbsd2.*|i?86-*openbsd3.[0123] so is right on spot it seems.
>>
>> Alternatively remove openbsd <= 3.3 support altogether since openbsd-3.3
>> was
>> released May 1, 2003.
>> This probably needs a deprecation announcement from Release Managers or
>> something.
>>
>> gcc/ChangeLog:
>>
>> 2015-04-10 Bernhard Reutner-Fischer <aldot@gcc.gnu.org>
>>
>> PR target/47098
>> * config/openbsd-oldgas.h (OBSD_LIB_SPEC): Add.
>
> OK.
Thanks, committed to trunk as r222315.
>
> If you want to deprecate the ancient openbsd support, that can be a
> follow-up.
I wouldn't dare :)
thanks,
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-04-22 8:42 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-04-11 22:15 [PATCH] PR target/47098 OBSD_LIB_SPEC on i686-openbsd3 missing Bernhard Reutner-Fischer
2015-04-13 13:08 ` Jeff Law
2015-04-22 8:42 ` Bernhard Reutner-Fischer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).