From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11039 invoked by alias); 13 Apr 2015 13:42:46 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 11029 invoked by uid 89); 13 Apr 2015 13:42:46 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.2 X-HELO: eu-smtp-delivery-143.mimecast.com Received: from eu-smtp-delivery-143.mimecast.com (HELO eu-smtp-delivery-143.mimecast.com) (146.101.78.143) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 13 Apr 2015 13:42:45 +0000 Received: from cam-owa1.Emea.Arm.com (fw-tnat.cambridge.arm.com [217.140.96.140]) by uk-mta-23.uk.mimecast.lan; Mon, 13 Apr 2015 14:42:42 +0100 Received: from [10.2.207.50] ([10.1.2.79]) by cam-owa1.Emea.Arm.com with Microsoft SMTPSVC(6.0.3790.3959); Mon, 13 Apr 2015 14:42:42 +0100 Message-ID: <552BC7D1.8010106@arm.com> Date: Mon, 13 Apr 2015 13:42:00 -0000 From: Kyrill Tkachov User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0 MIME-Version: 1.0 To: Yvan Roux , Jakub Jelinek CC: Vladimir Makarov , Terry Guo , gcc-patches Subject: Re: patch to fix PR65648 References: <5523F167.3010606@redhat.com> <20150407155143.GK19273@tucnak.redhat.com> <20150407193339.GN19273@tucnak.redhat.com> In-Reply-To: X-MC-Unique: NOKstxqEQgy3cqayQ7lkyw-1 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2015-04/txt/msg00587.txt.bz2 On 09/04/15 12:10, Yvan Roux wrote: > diff --git a/gcc/testsuite/gcc.target/arm/pr65648.c b/gcc/testsuite/gcc.t= arget/arm/pr65648.c > new file mode 100644 > index 0000000..e075546 > --- /dev/null > +++ b/gcc/testsuite/gcc.target/arm/pr65648.c > @@ -0,0 +1,9 @@ > +/* { dg-do run } */ > +/* { dg-skip-if "avoid conflicting multilib options" { *-*-* } { "-march= =3D*" } { "-march=3Darmv6" } } */ > +/* { dg-skip-if "avoid conflicting multilib options" { *-*-* } { "-marm"= } { "" } } */ > +/* { dg-skip-if "avoid conflicting multilib options" { *-*-*eabihf } { "= *" } { "" } } */ > +/* { dg-options "-mthumb -Os -mfloat-abi=3Dsoft" } */ > +/* { dg-add-options arm_arch_v6 } */ > + > +#include "../../gcc.c-torture/execute/pr65648.c" > + Hi Yvan, These are always tough to get right. How about: /* { dg-skip-if "avoid conflicting multilib options" { *-*-*eabihf } { "*" = } { "" } } */ /* { dg-options "-Os -mthumb -mfloat-abi=3Dsoft" } */ /* { dg-add-options arm_arch_v6 } */ /* { dg-require-effective-target arm_arch_v6_ok } */ ? I think the dg-skip-if will avoid the error when testing arm-none-linux-gn= ueabihf: "error: ./pr65648.exe uses VFP register arguments, /tmp/ccXpRQ41.o does n= ot" The dg-require-effective-target should remove the need for the first dg-ski= p-if in your options. I don't think it's worth skipping the test when the user explicitly asks fo= r -marm. It won't test the behaviour of the bug but then again, the user overrode the options, so pres= umably knows best. Is there any case where this fails? Kyrill