From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 91172 invoked by alias); 13 Apr 2015 21:08:06 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 91143 invoked by uid 89); 13 Apr 2015 21:08:06 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.6 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Mon, 13 Apr 2015 21:08:05 +0000 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (Postfix) with ESMTPS id EABF98EA48 for ; Mon, 13 Apr 2015 21:08:03 +0000 (UTC) Received: from [10.10.116.43] ([10.10.116.43]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t3DL83TO023442; Mon, 13 Apr 2015 17:08:03 -0400 Message-ID: <552C3031.5000405@redhat.com> Date: Mon, 13 Apr 2015 21:08:00 -0000 From: Jason Merrill User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Aldy Hernandez CC: gcc-patches Subject: Re: [debug-early] Handle specification of class scoped static functions References: <550C5F3A.1030802@redhat.com> <550C8F4C.1020003@redhat.com> <550CB740.6040305@redhat.com> <551EA84E.7080200@redhat.com> <552C048B.9020804@redhat.com> <552C2F77.7020408@redhat.com> In-Reply-To: <552C2F77.7020408@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2015-04/txt/msg00614.txt.bz2 On 04/13/2015 05:04 PM, Jason Merrill wrote: > On 04/13/2015 02:01 PM, Aldy Hernandez wrote: >> ...or perhaps we could change the condition to: >> >> if ((is_cu_die (old_die->die_parent) >> + || old_die->die_parent->die_tag == DW_TAG_module >> || context_die == NULL > > Does checking context_die == old_die->die_parent work? Actually, no. The comment here is saying that we don't want to reuse the DIE in this case, because we want the DIE with the source location info to be at CU scope. We only want to reuse if the function is at CU scope anyway or it's a nested function. Jason