From: Jason Merrill <jason@redhat.com>
To: Paolo Carlini <paolo.carlini@oracle.com>,
"gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>
Subject: Re: [C++ Patch] PR 65340
Date: Wed, 15 Apr 2015 01:31:00 -0000 [thread overview]
Message-ID: <552DBF66.4020101@redhat.com> (raw)
In-Reply-To: <5508DFD6.5070503@redhat.com>
On 03/17/2015 10:15 PM, Jason Merrill wrote:
> On 03/17/2015 10:03 PM, Paolo Carlini wrote:
>> On 03/18/2015 01:11 AM, Jason Merrill wrote:
>>> Are there other places that still need to pass complain to mark_used?
>> Well, if we are talking about functions getting a tsubst_flags_t and
>> *not* passing it down to mark_used, there are quite a few - see
>> attached. I didn't feel like raising the issue at this time because in
>> all those cases, at variance with the specific case we are changing for
>> the bug, the return value of mark_used is *not* checked, thus is we
>> suppress the errors in SFINAE context we would like to also add a check
>> and return early, but in general, doing that when we are *outside*
>> SFINAE changes what happens during error recovery, thus it seems a bit
>> risky fiddling with those right now...
>
> Agreed, let's defer this until stage 1.
I note that it's now stage 1. :)
There are various places in the compiler that error and continue if
tf_error is set, but return error_mark_node immediately if not; it seems
reasonable to follow that pattern in the places that don't currently
check the return value.
Jason
next prev parent reply other threads:[~2015-04-15 1:31 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-17 17:09 Paolo Carlini
2015-03-18 0:11 ` Jason Merrill
2015-03-18 2:03 ` Paolo Carlini
2015-03-18 2:15 ` Jason Merrill
2015-04-15 1:31 ` Jason Merrill [this message]
2015-04-15 8:44 ` Paolo Carlini
2015-04-16 12:29 ` Paolo Carlini
2015-04-16 14:34 ` Jason Merrill
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=552DBF66.4020101@redhat.com \
--to=jason@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=paolo.carlini@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).