From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 73589 invoked by alias); 17 Apr 2015 16:53:54 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 73578 invoked by uid 89); 17 Apr 2015 16:53:54 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Fri, 17 Apr 2015 16:53:53 +0000 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t3HGrpq7005466 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Fri, 17 Apr 2015 12:53:52 -0400 Received: from localhost.localdomain (ovpn-113-81.phx2.redhat.com [10.3.113.81]) by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t3HGrp4K018428; Fri, 17 Apr 2015 12:53:51 -0400 Message-ID: <55313A9F.6040304@redhat.com> Date: Fri, 17 Apr 2015 16:53:00 -0000 From: Jeff Law User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Yoshinori Sato , gcc-patches@gcc.gnu.org Subject: Re: [PATCH] Add new target h8300-*-linux References: <87twxz75id.wl-ysato@users.sourceforge.jp> In-Reply-To: <87twxz75id.wl-ysato@users.sourceforge.jp> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2015-04/txt/msg00909.txt.bz2 On 03/05/2015 09:50 AM, Yoshinori Sato wrote: > Add h8300-*-linux target for h8300 linux kernel and userland. > > h8300-*-elf is some difference of standard elf. > h8300-*-linux is compatible of standard elf rules. > > Thanks. > > diff --git a/gcc/ChangeLog b/gcc/ChangeLog > index cfacea1..fc5101c 100644 > --- a/gcc/ChangeLog > +++ b/gcc/ChangeLog > @@ -1,3 +1,12 @@ > +2015-03-06 Yoshinori Sato > + > + * config.gcc: Add h8300-*-linux > + * config/h8300/h8300.c (h8300_option_override): > + Exclusive -mh vs -ms/-msx > + (h8300_file_start): Target priority -msx > -ms > -mh > + * config/h8300/linux.h: New file. > + * config/h8300/t-linux: Likewise. Mostly OK. Two minor issues/questions that need to be addressed, then this ought to be able to be committed to the trunk. > > + if (TARGET_H8300H && (TARGET_H8300S || TARGET_H8300SX)) > + { > + target_flags ^= MASK_H8300H; > + } I'm a bit concerned by this. Why did you need to make this change? > +#undef LINK_SPEC > +#define LINK_SPEC "%{mh:%{!mn:-m h8300helf_linux}} %{ms:%{!mn:-m h8300self_linux}}" Presumably you don't need to support normal mode or the older H8/300 processor. Does that allow you to simplify LINK_SPEC at all? I'm going to assume the sfp-machine.h contents are correct. You did file a copyright form with the FSF, right (I believe I asked before, but I don't recall the result). Jeff