From: Richard Earnshaw <Richard.Earnshaw@foss.arm.com>
To: Yvan Roux <yvan.roux@linaro.org>,
Vladimir Makarov <vmakarov@redhat.com>
Cc: "gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>
Subject: Re: patch for PR65729
Date: Sat, 18 Apr 2015 14:22:00 -0000 [thread overview]
Message-ID: <553268A2.9020408@foss.arm.com> (raw)
In-Reply-To: <CAD57uCfo3DziR8zoNQmbHueqyD19dvDTofw1cybKkdDSh_fMnQ@mail.gmail.com>
On 15/04/15 13:51, Yvan Roux wrote:
> Hi,
>
> On 14 April 2015 at 17:36, Vladimir Makarov <vmakarov@redhat.com> wrote:
>> On 04/14/2015 04:11 AM, Jakub Jelinek wrote:
>>>
>>> On Tue, Apr 14, 2015 at 10:08:24AM +0200, Yvan Roux wrote:
>>>>
>>>> --- a/gcc/lra-constraints.c
>>>> +++ b/gcc/lra-constraints.c
>>>> @@ -1656,8 +1656,7 @@ prohibited_class_reg_set_mode_p (enum reg_class
>>>> rclass,
>>>> {
>>>> HARD_REG_SET temp;
>>>> - // ??? Is this assert right
>>>> - // lra_assert (hard_reg_set_subset_p (set,
>>>> reg_class_contents[rclass]));
>>>> + lra_assert (hard_reg_set_subset_p (reg_class_contents[rclass],set));
>>>
>>> Missing space after ,
>>> Otherwise, I'll defer to Vlad for review.
>>>
>>>
>> The patch is ok for me to commit it into the trunk. Thanks, Yvan.
>
> The testcase needs the hard float ABI support, and can fail if tested
> in a way the -march=armv7-a is overridden. This patch patch restrict
> the test to hard vfp compliant targets. Ok for trunk ?
>
> Thanks,
> Yvan
>
> 2015-04-15 Yvan Roux <yvan.roux@st.com>
>
> * gcc.target/arm/pr65729.c: Restrict to hard float ABI compliant targets.
>
OK.
prev parent reply other threads:[~2015-04-18 14:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-10 16:39 Vladimir Makarov
2015-04-14 8:08 ` Yvan Roux
2015-04-14 8:11 ` Jakub Jelinek
2015-04-14 15:36 ` Vladimir Makarov
2015-04-15 12:51 ` Yvan Roux
2015-04-18 14:22 ` Richard Earnshaw [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=553268A2.9020408@foss.arm.com \
--to=richard.earnshaw@foss.arm.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=vmakarov@redhat.com \
--cc=yvan.roux@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).