From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-patches-return-395414-listarch-gcc-patches=gcc.gnu.org@gcc.gnu.org>
Received: (qmail 98415 invoked by alias); 18 Apr 2015 14:22:32 -0000
Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-patches.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-patches/>
List-Post: <mailto:gcc-patches@gcc.gnu.org>
List-Help: <mailto:gcc-patches-help@gcc.gnu.org>
Sender: gcc-patches-owner@gcc.gnu.org
Received: (qmail 98404 invoked by uid 89); 18 Apr 2015 14:22:31 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-1.0 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,T_RP_MATCHES_RCVD autolearn=no version=3.3.2
X-HELO: foss.arm.com
Received: from foss.arm.com (HELO foss.arm.com) (217.140.101.70) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sat, 18 Apr 2015 14:22:30 +0000
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249])	by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 5575C546;	Sat, 18 Apr 2015 07:22:13 -0700 (PDT)
Received: from [192.168.1.21] (usa-sjc-mx-foss1.foss.arm.com [217.140.101.70])	by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 7A1593F3E7;	Sat, 18 Apr 2015 07:22:28 -0700 (PDT)
Message-ID: <553268A2.9020408@foss.arm.com>
Date: Sat, 18 Apr 2015 14:22:00 -0000
From: Richard Earnshaw <Richard.Earnshaw@foss.arm.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0
MIME-Version: 1.0
To: Yvan Roux <yvan.roux@linaro.org>,  Vladimir Makarov <vmakarov@redhat.com>
CC: "gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>
Subject: Re: patch for PR65729
References: <5527FCAC.3090205@redhat.com>	<CAD57uCezAGmX_ag9kaEdKLUEyLSzeDaFdBbfwgZWG6bZHo3P6w@mail.gmail.com>	<20150414081123.GF1725@tucnak.redhat.com>	<552D3412.6070100@redhat.com> <CAD57uCfo3DziR8zoNQmbHueqyD19dvDTofw1cybKkdDSh_fMnQ@mail.gmail.com>
In-Reply-To: <CAD57uCfo3DziR8zoNQmbHueqyD19dvDTofw1cybKkdDSh_fMnQ@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-IsSubscribed: yes
X-SW-Source: 2015-04/txt/msg00954.txt.bz2

On 15/04/15 13:51, Yvan Roux wrote:
> Hi,
> 
> On 14 April 2015 at 17:36, Vladimir Makarov <vmakarov@redhat.com> wrote:
>> On 04/14/2015 04:11 AM, Jakub Jelinek wrote:
>>>
>>> On Tue, Apr 14, 2015 at 10:08:24AM +0200, Yvan Roux wrote:
>>>>
>>>> --- a/gcc/lra-constraints.c
>>>> +++ b/gcc/lra-constraints.c
>>>> @@ -1656,8 +1656,7 @@ prohibited_class_reg_set_mode_p (enum reg_class
>>>> rclass,
>>>>   {
>>>>     HARD_REG_SET temp;
>>>>     -  // ??? Is this assert right
>>>> -  // lra_assert (hard_reg_set_subset_p (set,
>>>> reg_class_contents[rclass]));
>>>> +  lra_assert (hard_reg_set_subset_p (reg_class_contents[rclass],set));
>>>
>>> Missing space after ,
>>> Otherwise, I'll defer to Vlad for review.
>>>
>>>
>> The patch is ok for me to commit it into the trunk.  Thanks, Yvan.
> 
> The testcase needs the hard float ABI support, and can fail if tested
> in a way the -march=armv7-a  is overridden.  This patch patch restrict
> the test to hard vfp compliant targets.  Ok for trunk ?
> 
> Thanks,
> Yvan
> 
> 2015-04-15  Yvan Roux  <yvan.roux@st.com>
> 
>     * gcc.target/arm/pr65729.c: Restrict to hard float ABI compliant targets.
> 

OK.