From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 40661 invoked by alias); 21 Apr 2015 13:51:18 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 40650 invoked by uid 89); 21 Apr 2015 13:51:17 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.9 required=5.0 tests=AWL,BAYES_40,SPF_HELO_PASS,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Tue, 21 Apr 2015 13:51:16 +0000 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (Postfix) with ESMTPS id 80D0E2BB3B8; Tue, 21 Apr 2015 13:51:15 +0000 (UTC) Received: from localhost.localdomain (ovpn-113-145.phx2.redhat.com [10.3.113.145]) by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t3LDpEST015903; Tue, 21 Apr 2015 09:51:15 -0400 Message-ID: <553655D2.40200@redhat.com> Date: Tue, 21 Apr 2015 13:51:00 -0000 From: Jeff Law User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: tbsaunde+gcc@tbsaunde.org, gcc-patches@gcc.gnu.org Subject: Re: [PATCH 03/12] more removal of ifdef HAVE_cc0 References: <1429622658-9034-1-git-send-email-tbsaunde+gcc@tbsaunde.org> <1429622658-9034-4-git-send-email-tbsaunde+gcc@tbsaunde.org> In-Reply-To: <1429622658-9034-4-git-send-email-tbsaunde+gcc@tbsaunde.org> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2015-04/txt/msg01176.txt.bz2 On 04/21/2015 07:24 AM, tbsaunde+gcc@tbsaunde.org wrote: > From: Trevor Saunders > > gcc/ChangeLog: > > 2015-04-21 Trevor Saunders > > * combine.c (find_single_use): Remove HAVE_cc0 ifdef for code > that is trivially ded on non cc0 targets. > (simplify_set): Likewise. > (mark_used_regs_combine): Likewise. > * cse.c (new_basic_block): Likewise. > (fold_rtx): Likewise. > (cse_insn): Likewise. > (cse_extended_basic_block): Likewise. > (set_live_p): Likewise. > * rtlanal.c (canonicalize_condition): Likewise. > * simplify-rtx.c (simplify_binary_operation_1): Likewise. OK. I find myself wondering if the conditionals should look like if (HAVE_cc0 && (whatever)) But I doubt it makes any measurable difference. It's something we can always add in the future if we feel the need to avoid the runtime checks for things that aren't ever going to happen on most modern targets. jeff