From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 48526 invoked by alias); 22 Apr 2015 18:37:02 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 48513 invoked by uid 89); 22 Apr 2015 18:37:02 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Wed, 22 Apr 2015 18:37:00 +0000 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t3MIawjF029025 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Wed, 22 Apr 2015 14:36:58 -0400 Received: from localhost.localdomain (ovpn-113-113.phx2.redhat.com [10.3.113.113]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t3MIawdk030923; Wed, 22 Apr 2015 14:36:58 -0400 Message-ID: <5537EA4A.2010901@redhat.com> Date: Wed, 22 Apr 2015 18:37:00 -0000 From: Jeff Law User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: David Malcolm , Trevor Saunders CC: tbsaunde+gcc@tbsaunde.org, gcc-patches@gcc.gnu.org Subject: Re: [PATCH 00/12] Reduce conditional compilation References: <1429622658-9034-1-git-send-email-tbsaunde+gcc@tbsaunde.org> <5536573F.4090005@redhat.com> <20150421152914.GE9945@tsaunders-iceball.corp.tor1.mozilla.com> <1429726381.32584.146.camel@surprise> In-Reply-To: <1429726381.32584.146.camel@surprise> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2015-04/txt/msg01354.txt.bz2 On 04/22/2015 12:13 PM, David Malcolm wrote: > > Conditional compilation was a major PITA when doing the rtx->rtx_insn * > work last year, so I'm very pleased to see these cleanups go in. Yup. It also got in Andrew's way last year and we regularly see cases where small patches which work fine on the mainstream architectures fail to build in the lesser used architectures (particularly cc0 targets). It's a whole class of problems I want to see slowly disappear. glibc went through this process in their codebase for similar reasons, but they had more to lose when they got it wrong -- IIRC they had a case where exported ABI would differ as a result of conditionally compiled code. Not good. Jeff