From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 60043 invoked by alias); 23 Apr 2015 08:19:10 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 60032 invoked by uid 89); 23 Apr 2015 08:19:09 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.2 X-HELO: eu-smtp-delivery-143.mimecast.com Received: from eu-smtp-delivery-143.mimecast.com (HELO eu-smtp-delivery-143.mimecast.com) (207.82.80.143) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 23 Apr 2015 08:19:08 +0000 Received: from cam-owa2.Emea.Arm.com (fw-tnat.cambridge.arm.com [217.140.96.140]) by uk-mta-2.uk.mimecast.lan; Thu, 23 Apr 2015 09:19:04 +0100 Received: from [10.2.207.50] ([10.1.2.79]) by cam-owa2.Emea.Arm.com with Microsoft SMTPSVC(6.0.3790.3959); Thu, 23 Apr 2015 09:19:04 +0100 Message-ID: <5538AAF8.7060001@arm.com> Date: Thu, 23 Apr 2015 08:19:00 -0000 From: Kyrill Tkachov User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0 MIME-Version: 1.0 To: Bin Cheng , "gcc-patches@gcc.gnu.org" Subject: Re: [PATCH ARM]Fix pr42172-1.c failure on pre armv7 processors References: <000801d07cd8$42809e90$c781dbb0$@arm.com> In-Reply-To: <000801d07cd8$42809e90$c781dbb0$@arm.com> X-MC-Unique: yIkknQe9SVezh-N5jrKR0A-1 Content-Type: text/plain; charset=WINDOWS-1252; format=flowed Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2015-04/txt/msg01383.txt.bz2 On 22/04/15 09:42, Bin Cheng wrote: > Hi, > Case pr42172-1.c failed on pre-armv7 processors because GCC actually > generates better code without ldr instruction. This patch just refines t= est > case by checking str instead of ldr, makes sure the case passes on all arm > processors. In the end, we need to fix GCC combiner to generate optimal > code on armv7 processors too. PR42172 is kept open for that purpose. > > This is obvious change, is it OK for branches too? For the record, for -mcpu=3Darm7tdmi we now generate: init_A: mov r3, #8 strb r3, [r0] bx Ok for trunk. Is this test failing on the branches too? Kyrill > > gcc/testsuite/ChangeLog > 2015-04-22 Bin Cheng > > * gcc.target/arm/pr42172-1.c: Check str instead of ldr. >