From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30380 invoked by alias); 23 Apr 2015 08:41:19 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 28523 invoked by uid 89); 23 Apr 2015 08:41:19 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.2 X-HELO: eu-smtp-delivery-143.mimecast.com Received: from eu-smtp-delivery-143.mimecast.com (HELO eu-smtp-delivery-143.mimecast.com) (207.82.80.143) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 23 Apr 2015 08:41:18 +0000 Received: from cam-owa1.Emea.Arm.com (fw-tnat.cambridge.arm.com [217.140.96.140]) by uk-mta-14.uk.mimecast.lan; Thu, 23 Apr 2015 09:41:15 +0100 Received: from [10.2.207.50] ([10.1.2.79]) by cam-owa1.Emea.Arm.com with Microsoft SMTPSVC(6.0.3790.3959); Thu, 23 Apr 2015 09:41:14 +0100 Message-ID: <5538B02A.5050705@arm.com> Date: Thu, 23 Apr 2015 08:41:00 -0000 From: Kyrill Tkachov User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0 MIME-Version: 1.0 To: Richard Biener , Trevor Saunders CC: James Greenhalgh , "tbsaunde+gcc@tbsaunde.org" , GCC Patches , Richard Earnshaw , Ramana Radhakrishnan , "nickc@redhat.com" , Bin Cheng , Bernd Schmidt Subject: Re: [PATCH 02/12] remove some ifdef HAVE_cc0 References: <1429622658-9034-1-git-send-email-tbsaunde+gcc@tbsaunde.org> <1429622658-9034-3-git-send-email-tbsaunde+gcc@tbsaunde.org> <20150421152444.GD9945@tsaunders-iceball.corp.tor1.mozilla.com> <20150423032756.GA16004@arm.com> <20150423045406.GA2949@tsaunders-iceball.corp.tor1.mozilla.com> In-Reply-To: X-MC-Unique: N1sWhqnWTiCaeEyx43X8DA-1 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2015-04/txt/msg01391.txt.bz2 On 23/04/15 09:35, Richard Biener wrote: > On Thu, Apr 23, 2015 at 6:54 AM, Trevor Saunders = wrote: >> On Thu, Apr 23, 2015 at 04:27:59AM +0100, James Greenhalgh wrote: >>> On Tue, Apr 21, 2015 at 04:24:44PM +0100, Trevor Saunders wrote: >>>> On Tue, Apr 21, 2015 at 04:14:01PM +0200, Richard Biener wrote: >>>>> On Tue, Apr 21, 2015 at 3:24 PM, wrote: >>>>>> From: Trevor Saunders >>>>>> >>>>>> gcc/ChangeLog: >>>>>> >>>>>> 2015-04-21 Trevor Saunders >>>>>> >>>>>> * conditions.h: Define macros even if HAVE_cc0 is undefined. >>>>>> * emit-rtl.c: Define functions even if HAVE_cc0 is undefine= d. >>>>>> * final.c: Likewise. >>>>>> * jump.c: Likewise. >>>>>> * recog.c: Likewise. >>>>>> * recog.h: Declare functions even when HAVE_cc0 is undefine= d. >>>>>> * sched-deps.c (sched_analyze_2): Always compile case for c= c0. >>> If I've counted right after the git bisect, this patch seems to break >>> the ARM buildi (arm-none-linux-gnueabihf): >>> >>> In file included from insn-output.c:40:0: >>> ..../gcc-src/gcc/conditions.h:112:0: error: "CC_STATUS_INIT" redefin= ed [-Werror] >>> #define CC_STATUS_INIT \ This is a warning-to-error from -Werror, so this came out during bootstrap rather than a cross-build, right? >>> ^ >>> In file included from tm.h:35:0, >>> from insn-output.c:7: >>> ..../gcc-src/gcc/config/arm/arm.h:2159:0: note: this is the location= of the previous definition >>> #define CC_STATUS_INIT \ >>> ^ >>> >>> I guess the conditions.h definition wants wrapping in #ifndef - though a >>> quick grep suggests that ARM is the only target defining CC_STATUS_INIT >>> so lets CC the ARM maintainers and see what their preference is... >> Well, that seems pretty weird, but it looks intentional arm does this >> see http://gcc.gnu.org/ml/gcc-patches/2010-07/msg00437.html >> >> Of course I now see final.c also defines a fall back, so maybe the right >> thing to do is wrap the conditions.h definition in #if HAVE_cc0, or >> maybe the final.c definition can go away? Right now I'm to tired to make >> a good decision about that. >> >> sorry about the bustage! > Looks like the best thing is to turn this into a target hook then? Or mo= ve the > fallback/default to defaults.h Shall we revert this patch for now then to restore bootstrap? Kyrill > > Richard. > >> Trev >> >> >>> Thanks, >>> James