From: Kyrill Tkachov <kyrylo.tkachov@arm.com>
To: "Bin.Cheng" <amker.cheng@gmail.com>
Cc: Bin Cheng <Bin.Cheng@arm.com>,
"gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH ARM]Fix pr42172-1.c failure on pre armv7 processors
Date: Thu, 23 Apr 2015 09:04:00 -0000 [thread overview]
Message-ID: <5538B5A9.8000202@arm.com> (raw)
In-Reply-To: <CAHFci2_cxAad+5bOgu2tbmLbfFCTztpeTdHyPXMeWRFWLB=jhw@mail.gmail.com>
On 23/04/15 09:53, Bin.Cheng wrote:
> On Thu, Apr 23, 2015 at 4:19 PM, Kyrill Tkachov <kyrylo.tkachov@arm.com> wrote:
>> On 22/04/15 09:42, Bin Cheng wrote:
>>> Hi,
>>> Case pr42172-1.c failed on pre-armv7 processors because GCC actually
>>> generates better code without ldr instruction. This patch just refines
>>> test
>>> case by checking str instead of ldr, makes sure the case passes on all arm
>>> processors. In the end, we need to fix GCC combiner to generate optimal
>>> code on armv7 processors too. PR42172 is kept open for that purpose.
>>>
>>> This is obvious change, is it OK for branches too?
>>
>> For the record, for -mcpu=arm7tdmi we now generate:
>> init_A:
>> mov r3, #8
>> strb r3, [r0]
>> bx
> That's the point, it generates optimal code for pre-armv7 processors,
> which is treated as failure now.
>
>>
>> Ok for trunk. Is this test failing on the branches too?
> Well, at least for gcc-5-branch.
If the GCC 5 branch is now open for commits (I think it is?), then ok there too.
Kyrill
>
>> Kyrill
>>
>>
>>> gcc/testsuite/ChangeLog
>>> 2015-04-22 Bin Cheng <bin.cheng@arm.com>
>>>
>>> * gcc.target/arm/pr42172-1.c: Check str instead of ldr.
>>>
prev parent reply other threads:[~2015-04-23 9:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-22 8:42 Bin Cheng
2015-04-23 8:19 ` Kyrill Tkachov
2015-04-23 8:53 ` Bin.Cheng
2015-04-23 9:04 ` Kyrill Tkachov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5538B5A9.8000202@arm.com \
--to=kyrylo.tkachov@arm.com \
--cc=Bin.Cheng@arm.com \
--cc=amker.cheng@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).