public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Jeff Law <law@redhat.com>
To: Jan Kratochvil <jan.kratochvil@redhat.com>, gcc-patches@gcc.gnu.org
Cc: Phil Muldoon <pmuldoon@redhat.com>
Subject: Re: [PATCH v2 4/4] libcc1: 'set debug compile': Display absolute GCC driver filename
Date: Thu, 23 Apr 2015 21:57:00 -0000	[thread overview]
Message-ID: <55396ABE.5060102@redhat.com> (raw)
In-Reply-To: <20150423203849.23973.43273.stgit@host1.jankratochvil.net>

On 04/23/2015 02:38 PM, Jan Kratochvil wrote:
> Hi,
>
> already approved, maybe it could be already checked in outside of the series:
> 	https://gcc.gnu.org/ml/gcc-patches/2015-04/msg01298.html
>
> With the patches so far after
>          (gdb) set debug compile 1
> one would get:
>          searching for compiler matching regex ^(x86_64|i.86)(-[^-]*)?-linux(-gnu)?-gcc$
>          found compiler x86_64-unknown-linux-gnu-gcc
> But I believe it is more readable to see:
>          searching for compiler matching regex ^(x86_64|i.86)(-[^-]*)?-linux(-gnu)?-gcc$
>          found compiler /usr/bin/x86_64-unknown-linux-gnu-gcc
>
> I do not think the change will have functionality impact, although the filename
> gets used even for executing the command.
>
>
> Jan
>
>
> libcc1/ChangeLog
> 2015-04-21  Jan Kratochvil  <jan.kratochvil@redhat.com>
>
> 	* findcomp.cc: Include system.h.
> 	(search_dir): Return absolute filename.
Still OK :-)
jeff

  reply	other threads:[~2015-04-23 21:57 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-23 20:38 [PATCH v2 1/4] libcc1: Introduce GCC_FE_VERSION_1 Jan Kratochvil
2015-04-23 20:38 ` [PATCH v2 3/4] libcc1: Add 'set compile-gcc' Jan Kratochvil
2015-04-23 21:57   ` Jeff Law
2015-04-27 15:23   ` Pedro Alves
2015-04-23 20:38 ` [PATCH v2 4/4] libcc1: 'set debug compile': Display absolute GCC driver filename Jan Kratochvil
2015-04-23 21:57   ` Jeff Law [this message]
2015-04-23 20:38 ` [PATCH v2 2/4] libcc1: set debug compile: Display " Jan Kratochvil
2015-04-23 20:42   ` Jan Kratochvil
2015-04-23 21:56   ` Jeff Law
2015-04-23 21:54 ` [PATCH v2 1/4] libcc1: Introduce GCC_FE_VERSION_1 Jeff Law

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55396ABE.5060102@redhat.com \
    --to=law@redhat.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=jan.kratochvil@redhat.com \
    --cc=pmuldoon@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).