From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 93115 invoked by alias); 23 Apr 2015 22:00:54 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 92544 invoked by uid 89); 23 Apr 2015 22:00:54 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Thu, 23 Apr 2015 22:00:53 +0000 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t3NM0mhQ023485 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Thu, 23 Apr 2015 18:00:49 -0400 Received: from localhost.localdomain (ovpn-113-113.phx2.redhat.com [10.3.113.113]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t3NM0lPg028150; Thu, 23 Apr 2015 18:00:47 -0400 Message-ID: <55396B8F.8010600@redhat.com> Date: Thu, 23 Apr 2015 22:00:00 -0000 From: Jeff Law User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Marek Polacek , GCC Patches CC: Dodji Seketeli , Joseph Myers , =?windows-1252?Q?Manuel_L=F3pez-Ib=E1=F1ez?= Subject: Re: [PATCH] Quiet down -Wlogical-op a bit (PR c/61534) References: <20150422135631.GG28950@redhat.com> In-Reply-To: <20150422135631.GG28950@redhat.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2015-04/txt/msg01459.txt.bz2 On 04/22/2015 07:56 AM, Marek Polacek wrote: > This patch stifles -Wlogical-op a bit: don't warn if either operand comes from > a macro expansion. As the comment says, it doesn't fix the bug completely, but > it's a simple improvement. I did this by introducing a new macro. > > Bootstrapped/regtested on x86_64-linux, ok for trunk? > (Bootstrap with -Wlogical-op enabled does not pass yet.) > > 2015-04-22 Marek Polacek > > PR c/61534 > * input.h (from_macro_expansion_at): Define. > > * c-common.c (warn_logical_operator): Bail if either operand comes > from a macro expansion. > > * c-c++-common/pr61534-1.c: New test. OK. jeff