From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30163 invoked by alias); 27 Apr 2015 11:02:23 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 30147 invoked by uid 89); 27 Apr 2015 11:02:22 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.2 X-HELO: eu-smtp-delivery-143.mimecast.com Received: from eu-smtp-delivery-143.mimecast.com (HELO eu-smtp-delivery-143.mimecast.com) (146.101.78.143) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 27 Apr 2015 11:02:20 +0000 Received: from cam-owa1.Emea.Arm.com (fw-tnat.cambridge.arm.com [217.140.96.140]) by uk-mta-5.uk.mimecast.lan; Mon, 27 Apr 2015 12:02:17 +0100 Received: from [10.2.207.50] ([10.1.2.79]) by cam-owa1.Emea.Arm.com with Microsoft SMTPSVC(6.0.3790.3959); Mon, 27 Apr 2015 12:02:17 +0100 Message-ID: <553E1739.2010102@arm.com> Date: Mon, 27 Apr 2015 11:02:00 -0000 From: Kyrill Tkachov User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0 MIME-Version: 1.0 To: Kugan , James Greenhalgh CC: "gcc-patches@gcc.gnu.org" , Marcus Shawcroft , Richard Earnshaw , Jim Wilson , Ramana Radhakrishnan Subject: Re: [ARM] Fix RTX cost for vector SET References: <5506D77B.5060909@linaro.org> <55070972.3000800@arm.com> <5507813E.3060106@linaro.org> <5513B390.2030201@linaro.org> <552D8FF7.5000105@linaro.org> <20150415092509.GA20852@arm.com> <552E4150.3020403@linaro.org> <20150415111854.GB22143@arm.com> <552E4C90.4070208@linaro.org> <5530EC32.4030806@linaro.org> <20150420202225.GA7414@arm.com> <553AD118.3010705@linaro.org> <553AD20A.9020108@linaro.org> In-Reply-To: <553AD20A.9020108@linaro.org> X-MC-Unique: 7nx0A07fQdugyd0bynmHaA-1 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2015-04/txt/msg01601.txt.bz2 Hi Kugan, On 25/04/15 00:30, Kugan wrote: >> Thanks for the review. I have updated the patch based on the comments >> with some other minor changes. Bootstrapped and regression tested on >> aarch64-none-linux-gnu with no-new regressions. Is this OK for trunk? >> >> >> Thanks, >> Kugan >> >> >> gcc/ChangeLog: >> >> 2015-04-24 Kugan Vivekanandarajah >> Jim Wilson >> >> * config/arm/aarch-common-protos.h (struct mem_cost_table): Added >> new fields loadv and storev. >> * config/aarch64/aarch64-cost-tables.h (thunderx_extra_costs): >> Initialize loadv and storev. >> * config/arm/aarch-cost-tables.h (generic_extra_costs): Likewise. >> (cortexa53_extra_costs): Likewise. >> (cortexa57_extra_costs): Likewise. >> (xgene1_extra_costs): Likewise. >> * config/aarch64/aarch64.c (aarch64_rtx_costs): Update vector >> rtx_costs. >> > Due to the struct mem_cost_table update for aarch64, arm cost tables > also need to be updated. Please find the patch that does this. > Regression tested on arm-none-linux-gnu with no-new regressions. Is this > OK for trunk? > > Thanks, > Kugan > > gcc/ChangeLog: > > 2015-04-25 Kugan Vivekanandarajah > > * config/arm/arm.c (cortexa9_extra_costs): Initialize loadv and > storev. > (cortexa8_extra_costs): Likewise. > (cortexa5_extra_costs): Likewise. > (cortexa7_extra_costs): Likewise. > (cortexa12_extra_costs): Likewise. > (cortexa15_extra_costs): Likewise. > (v7m_extra_costs): Likewise. This arm part looks ok to me FWIW (if the approach in the aarch64 patch is deemed ok by the aarch64 maintainers), it just syncs the fields of the common cost struct between arm and aarch64. Please only commit this if the aarch64 patch gets approved and committed at the same time, otherwise we'll get a build failure. Having a look at the arm rtx costs and seeing if we can improve them in the same way as the aarch64 ones would be good as a follow up at some point too. Thanks, Kyrill