public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Jeff Law <law@redhat.com>
To: Marek Polacek <polacek@redhat.com>,
	GCC Patches <gcc-patches@gcc.gnu.org>,
	       Joseph Myers <joseph@codesourcery.com>
Subject: Re: C PATCH to reject va_arg (ap, void) (PR c/65901)
Date: Mon, 27 Apr 2015 17:56:00 -0000	[thread overview]
Message-ID: <553E782C.5010701@redhat.com> (raw)
In-Reply-To: <20150427173052.GA11448@redhat.com>

On 04/27/2015 11:30 AM, Marek Polacek wrote:
> As reported in the PR, va_arg (ap, void) probably doesn't make any sense and
> should be rejected thus.  cc1plus and clang reject va_arg with an incomplete
> type.  This patch makes cc1 reject it as well.
>
> Bootstrapped/regtested on x86_64-linux, ok for trunk?
>
> 2015-04-27  Marek Polacek  <polacek@redhat.com>
>
> 	PR c/65901
> 	* c-typeck.c (c_build_va_arg): Require TYPE be a complete type.
>
> 	* gcc.c-torture/compile/pr48767.c (foo): Add dg-error.
> 	* gcc.dg/pr65901.c: New test.
OK.
jeff

  reply	other threads:[~2015-04-27 17:56 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-27 17:30 Marek Polacek
2015-04-27 17:56 ` Jeff Law [this message]
2015-04-29  3:50 ` Martin Sebor
2015-04-29 16:49   ` Marek Polacek
2015-04-30 14:17     ` Marek Polacek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=553E782C.5010701@redhat.com \
    --to=law@redhat.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=joseph@codesourcery.com \
    --cc=polacek@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).