From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 953E93858C30 for ; Thu, 27 Apr 2023 12:03:26 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 953E93858C30 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1682597005; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Ru31CE1X9yUJOMPokddJmdbuWq+CgDMQLD3cO1XUROQ=; b=Xkop5y9FVnWkfeqnIHkFSiXfDTqnSNmQxejrDsbFhkAOufyvvQ9eeIcIb+Eey67iEu0bS5 25ekk/dIQ08zC8ZASNHn3Y8wBn5EcnXMJIgGAIMot/jWc3FMrwqp7gGsVTSVN2rWK5bnBa atbQ00uZtn/+7cxUQ4fVM+6SJ5ueIgw= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-427-tSP3lsx9ObeLiGATF2fS1Q-1; Thu, 27 Apr 2023 08:03:23 -0400 X-MC-Unique: tSP3lsx9ObeLiGATF2fS1Q-1 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-3f17b8d24bbso53611955e9.2 for ; Thu, 27 Apr 2023 05:03:23 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682597002; x=1685189002; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Ru31CE1X9yUJOMPokddJmdbuWq+CgDMQLD3cO1XUROQ=; b=JKyYJsf+BvPL87jNNwscOePeVxl1JcCTW5MOAtpIrwioDKPaN40jg9Rqo10WeJAutK VnlXkKJUez6lPdsyX2koiM/a8EcHIYQh2KvLlFcJ7rYZjAN9uiOroa0E9VMrVVP7XM6j pswsgZEdWiYfKbo+YmAveg2ne/Y+0fVcMi6FqPE0Xm9MkXR8GBaJmmiH1XaqYb2jM8ZA OIZqhIzq32R5bbItysHEJrI07LCJ5rqCYcx/CREhAaDdUnMAu2QRr2iJFmybq+fux9Eg 8LgyZVTtnvHbR1udy2TmrcukMB8YC3eD1SzHokXDkPreeG63HHTXhFcHC+4LGtRyY7+i iveQ== X-Gm-Message-State: AC+VfDxKrrDUM7AdrGmN90Oy8X9TdDaF2906Dqk6HwJRDvmOEPGwbmkE nOT7VG9WsT7aXbllPUg+NAA7Rw0J7UGtZKN08qwRTRv3nyD5M9UUraFMcS3bt0b1oeuyzZzFX0F bT+GdCqij7DbH2QAo4BQ3pnItxA== X-Received: by 2002:a7b:c3c8:0:b0:3f1:745a:784 with SMTP id t8-20020a7bc3c8000000b003f1745a0784mr1238346wmj.23.1682597002167; Thu, 27 Apr 2023 05:03:22 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4az6VOf4QvHMp7IY6rFVzk79uVq3D/3vG4ADwGoUFbZBd43zG2g+BV1yAokDOkEn5uOi12PQ== X-Received: by 2002:a7b:c3c8:0:b0:3f1:745a:784 with SMTP id t8-20020a7bc3c8000000b003f1745a0784mr1238324wmj.23.1682597001823; Thu, 27 Apr 2023 05:03:21 -0700 (PDT) Received: from [192.168.1.201] ([139.47.42.170]) by smtp.gmail.com with ESMTPSA id v9-20020a05600c444900b003f173be2ccfsm32304263wmn.2.2023.04.27.05.03.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 27 Apr 2023 05:03:21 -0700 (PDT) Message-ID: <553fbb54-f308-abba-8922-6265e51b4eec@redhat.com> Date: Thu, 27 Apr 2023 14:03:20 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH] v2: Implement range-op entry for sin/cos To: Jakub Jelinek Cc: GCC patches , Andrew MacLeod References: <20230418131250.310916-1-aldyh@redhat.com> <1c53d864-274c-33b9-d80a-16d4137d6100@redhat.com> From: Aldy Hernandez In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_BARRACUDACENTRAL,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,RCVD_IN_SBL_CSS,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 4/27/23 13:53, Jakub Jelinek wrote: > On Thu, Apr 27, 2023 at 01:46:19PM +0200, Aldy Hernandez wrote: >> On 4/27/23 13:13, Jakub Jelinek wrote: >> >>> + unsigned bulps = targetm.libm_function_max_error (m_cfn, TYPE_MODE (type), >>> + true); >>> + if (bulps == ~0U) >>> + r.set_varying (type); >>> + else if (bulps == 0) >>> + r.set (type, dconstm1, dconst1); >>> + else >>> + { >>> + REAL_VALUE_TYPE boundmin, boundmax; >>> + boundmax = dconst1; >>> + while (bulps--) >>> + frange_nextafter (TYPE_MODE (type), boundmax, dconstinf); >>> + real_arithmetic (&boundmin, NEGATE_EXPR, &boundmax, NULL); >>> + r.set (type, boundmin, boundmax); >>> + } >> >> This seems like something we'll do over and over for other operations, >> right? If so, could you abstract it into a separate function? > > Not easily. E.g. take the difference between sin/cos, where the above > grows the interval on both sides by bulps, vs. what I'm working on right now > (sqrt), where it grows in one direction only (from dconstm0 toward > dconstninf). There could be other functions which only grow the positive > bound. Fair enough. Then OK. Thanks for working on this. Aldy