From: Mikael Morin <mikael.morin@sfr.fr>
To: David Malcolm <dmalcolm@redhat.com>,
gcc-patches@gcc.gnu.org, thomas@codesourcery.com
Subject: Re: [PATCH 3/3] Fix indentation issues seen by -Wmisleading-indentation
Date: Wed, 29 Apr 2015 12:35:00 -0000 [thread overview]
Message-ID: <5540CA39.7070308@sfr.fr> (raw)
In-Reply-To: <1430265776-8157-3-git-send-email-dmalcolm@redhat.com>
Hello,
Le 29/04/2015 02:02, David Malcolm a écrit :
> diff --git a/gcc/fortran/parse.c b/gcc/fortran/parse.c
> index 2c7c554..30e4eab 100644
> --- a/gcc/fortran/parse.c
> +++ b/gcc/fortran/parse.c
> @@ -4283,7 +4283,7 @@ parse_oacc_structured_block (gfc_statement acc_st)
> unexpected_eof ();
> else if (st != acc_end_st)
> gfc_error ("Expecting %s at %C", gfc_ascii_statement (acc_end_st));
> - reject_statement ();
> + reject_statement ();
> }
> while (st != acc_end_st);
>
I think this one is a bug; there should be braces around 'gfc_error' and
'reject_statement'.
At least that's the pattern in 'parse_oacc_loop', and how the
'unexpected_statement' function is used.
Author CC'ed in any case.
Mikael
next prev parent reply other threads:[~2015-04-29 12:10 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-16 15:08 [RFC stage 1] Proposed new warning: -Wmisleading-indentation David Malcolm
2015-04-16 17:27 ` Mike Stump
2015-04-21 16:13 ` David Malcolm
2015-04-21 16:40 ` Trevor Saunders
2015-04-21 16:43 ` Manuel López-Ibáñez
2015-04-21 17:05 ` Mike Stump
2015-04-21 18:14 ` Manuel López-Ibáñez
2015-04-21 23:35 ` David Malcolm
2015-04-28 23:50 ` [PATCH 1/3] Implement -Wmisleading-indentation (v4) David Malcolm
2015-04-28 23:52 ` [PATCH 2/3] Fix spurious semicolons David Malcolm
2015-04-29 0:10 ` Jeff Law
2015-04-28 23:53 ` [PATCH 3/3] Fix indentation issues seen by -Wmisleading-indentation David Malcolm
2015-04-29 0:25 ` Jeff Law
2015-04-29 12:35 ` Mikael Morin [this message]
2015-05-05 19:44 ` David Malcolm
2015-05-06 11:38 ` Fix logic error in Fortran OpenACC parsing (was: [PATCH 3/3] Fix indentation issues seen by -Wmisleading-indentation) Thomas Schwinge
2015-05-08 11:24 ` Fix logic error in Fortran OpenACC parsing Ilmir Usmanov
2015-07-27 14:37 ` Thomas Schwinge
2015-05-11 21:23 ` [PATCH 1/3] Implement -Wmisleading-indentation (v4) Jeff Law
2015-05-12 21:28 ` David Malcolm
2015-05-12 21:47 ` David Malcolm
2015-08-18 14:13 ` PR67192 (Was: Re: [PATCH 1/3] Implement -Wmisleading-indentation (v4)) Andreas Arnez
2015-04-16 18:29 ` [RFC stage 1] Proposed new warning: -Wmisleading-indentation Manuel López-Ibáñez
2015-04-17 14:42 ` Tom Tromey
2015-04-17 16:12 ` Manuel López-Ibáñez
2015-04-28 23:13 ` Joseph Myers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5540CA39.7070308@sfr.fr \
--to=mikael.morin@sfr.fr \
--cc=dmalcolm@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=thomas@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).