From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 84548 invoked by alias); 29 Apr 2015 12:10:55 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 84538 invoked by uid 89); 29 Apr 2015 12:10:54 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: smtp23.services.sfr.fr Received: from smtp23.services.sfr.fr (HELO smtp23.services.sfr.fr) (93.17.128.19) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Wed, 29 Apr 2015 12:10:53 +0000 Received: from filter.sfr.fr (localhost [86.72.15.46]) by msfrf2302.sfr.fr (SMTP Server) with ESMTP id 9A7D370003E5; Wed, 29 Apr 2015 14:10:50 +0200 (CEST) Authentication-Results: sfrmc.priv.atos.fr; dkim=none (no signature); dkim-adsp=none (no policy) header.from=mikael.morin@sfr.fr Received: from tolstoi.localhost (46.15.72.86.rev.sfr.net [86.72.15.46]) (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by msfrf2302.sfr.fr (SMTP Server) with ESMTP id 3FEA170003D1; Wed, 29 Apr 2015 14:10:50 +0200 (CEST) X-SFR-UUID: 20150429121050261.3FEA170003D1@msfrf2302.sfr.fr Message-ID: <5540CA39.7070308@sfr.fr> Date: Wed, 29 Apr 2015 12:35:00 -0000 From: Mikael Morin User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: David Malcolm , gcc-patches@gcc.gnu.org, thomas@codesourcery.com Subject: Re: [PATCH 3/3] Fix indentation issues seen by -Wmisleading-indentation References: <5536936F.8090004@gmail.com> <1430265776-8157-1-git-send-email-dmalcolm@redhat.com> <1430265776-8157-3-git-send-email-dmalcolm@redhat.com> In-Reply-To: <1430265776-8157-3-git-send-email-dmalcolm@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit X-IsSubscribed: yes X-SW-Source: 2015-04/txt/msg01868.txt.bz2 Hello, Le 29/04/2015 02:02, David Malcolm a écrit : > diff --git a/gcc/fortran/parse.c b/gcc/fortran/parse.c > index 2c7c554..30e4eab 100644 > --- a/gcc/fortran/parse.c > +++ b/gcc/fortran/parse.c > @@ -4283,7 +4283,7 @@ parse_oacc_structured_block (gfc_statement acc_st) > unexpected_eof (); > else if (st != acc_end_st) > gfc_error ("Expecting %s at %C", gfc_ascii_statement (acc_end_st)); > - reject_statement (); > + reject_statement (); > } > while (st != acc_end_st); > I think this one is a bug; there should be braces around 'gfc_error' and 'reject_statement'. At least that's the pattern in 'parse_oacc_loop', and how the 'unexpected_statement' function is used. Author CC'ed in any case. Mikael