From: Alan Lawrence <alan.lawrence@arm.com>
To: "gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>
Cc: Marcus Shawcroft <Marcus.Shawcroft@arm.com>
Subject: Re: [PATCH][AArch64] Fix PR/65770 vstN_lane on bigendian
Date: Wed, 29 Apr 2015 13:34:00 -0000 [thread overview]
Message-ID: <5540DC1D.4060906@arm.com> (raw)
In-Reply-To: <552FF103.8010001@arm.com>
Alan Lawrence wrote:
> As per bugzilla entry, indices in the generated assembly for bigendian are
> flipped when they should not be (and, flipped always relative to a Q-register!).
>
> This flips the lane indices back again at assembly time, fixing PR. The
> "indices" contained in the RTL are still wrong for D registers, but these are
> only parameters to an UNSPEC and so never acted upon. (Nonetheless I intend to
> fix this anomaly in later patches).
>
> Tested check-gcc on aarch64-none-elf and aarch64_be-none-elf.
> New test (initially failing on bigendian) now passing on both.
>
> gcc/ChangeLog:
>
> PR target/65770
> config/aarch64/aarch64-simd.md (vec_store_lanesoi_lane<mode>,
> vec_store_lanesci_lane<mode>, vec_store_lanesxi_lane<mode>):
> Flip lane index back at assembly time for bigendian.
>
> gcc/testsuite/ChangeLog:
>
> PR target/65770
> gcc.target/aarch64/vstN_lane_1.c: New file.
Ping.
next prev parent reply other threads:[~2015-04-29 13:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-16 17:27 Alan Lawrence
2015-04-29 13:34 ` Alan Lawrence [this message]
2015-04-29 13:45 ` Marcus Shawcroft
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5540DC1D.4060906@arm.com \
--to=alan.lawrence@arm.com \
--cc=Marcus.Shawcroft@arm.com \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).