From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 84811 invoked by alias); 29 Apr 2015 13:59:55 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 84792 invoked by uid 89); 29 Apr 2015 13:59:53 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=0.1 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,T_RP_MATCHES_RCVD,UNSUBSCRIBE_BODY autolearn=no version=3.3.2 X-HELO: foss.arm.com Received: from foss.arm.com (HELO foss.arm.com) (217.140.101.70) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 29 Apr 2015 13:59:52 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 6240C564; Wed, 29 Apr 2015 06:59:25 -0700 (PDT) Received: from [10.2.207.50] (e100706-lin.cambridge.arm.com [10.2.207.50]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 1017B3F26A; Wed, 29 Apr 2015 06:59:49 -0700 (PDT) Message-ID: <5540E3D4.5090107@foss.arm.com> Date: Wed, 29 Apr 2015 14:10:00 -0000 From: Kyrill Tkachov User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0 MIME-Version: 1.0 To: James Greenhalgh CC: GCC Patches , Marcus Shawcroft , Richard Earnshaw Subject: Re: [PATCH][AArch64] Increase static buffer size in aarch64_rewrite_selected_cpu References: <55352847.8080302@arm.com> <20150420203001.GB7414@arm.com> In-Reply-To: <20150420203001.GB7414@arm.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2015-04/txt/msg01883.txt.bz2 On 20/04/15 21:30, James Greenhalgh wrote: > On Mon, Apr 20, 2015 at 05:24:39PM +0100, Kyrill Tkachov wrote: >> Hi all, >> >> When trying to compile a testcase with -mcpu=cortex-a57+crypto+nocrc I got >> the weird assembler error: >> Assembler messages: >> Error: missing architectural extension >> Error: unrecognized option -mcpu=cortex-a57+crypto+no >> >> The problem is the aarch64_rewrite_selected_cpu that is used to rewrite -mcpu >> for big.LITTLE options has a limit of 20 characters in what it handles, which >> we can exhaust quickly if we specify architectural extensions in a >> fine-grained manner. >> >> This patch increases that character limit to 128 and adds an assert to >> confirm that no bad things happen. > You've implemented this as a hard ICE, was that intended? > >> It also fixes another problem: If we pass a big.LITTLE combination with >> feature modifiers like: -mcpu=cortex-a57.cortex-a53+nosimd >> >> the code will truncate everything after '.', thus destroying the extensions >> that we want to pass. The patch adds code to stitch the extensions back on >> after the LITTLE cpu is removed. > UGH, I should not be allowed near strings! This code is on my list of > things I'd love to rewrite to this year! For now, this is OK and please > also queue it for 5.2 when that opens for patches. Hi all, Just to confirm. Is it ok to backport this patch to the GCC 5 branch? Thanks, Kyrill > >> Ok for trunk? > Yes, thanks. And sorry again for introducing this in the first place. > > James >