From: Jeff Law <law@redhat.com>
To: "rohitarulraj@freescale.com" <rohitarulraj@freescale.com>,
"gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>,
"rguenther@suse.de" <rguenther@suse.de>,
Jakub Jelinek <jakub@redhat.com>
Cc: Alan Modra <amodra@gmail.com>, David Edelsohn <dje.gcc@gmail.com>,
Edmar Wienskoski <edmar@freescale.com>
Subject: Re: [RFC: Patch, PR 60158] gcc/varasm.c : Pass actual alignment value to output_constant_pool_2
Date: Thu, 30 Apr 2015 15:15:00 -0000 [thread overview]
Message-ID: <554243E9.6030206@redhat.com> (raw)
In-Reply-To: <BLUPR03MB14580146D1439BC971C101C9C2D70@BLUPR03MB1458.namprd03.prod.outlook.com>
On 04/29/2015 04:30 AM, rohitarulraj@freescale.com wrote:
>>
>
> Jeff, I have made the changes as per your comments and attached the patch.
> If the patch is OK, I will proceed with the regression tests.
This patch refers back to 60158 and based on what I see in 60158, it
appears I should be looking for a .data.rel.ro.local section which
contains the address of a string constant. But the constants are being
put into .rodata.str1.4. And if the issue is we're putting bits into
the wrong section and don't have an appropriate .fixup section, then
ISTM that the test should be compiled, then objdump used to verify the
sections and/or relocations.
An additional concern is that I get the same code for the included
testcase with or without your changes. This is with a
powerpc-softfloat-linux-gnuspe configured compiler -- which matches what
I saw in pr 60158.
So while the patch seems reasonable, I'm concerned that I've been unable
to show it changing anything.
Thoughts?
Jeff
next prev parent reply other threads:[~2015-04-30 15:02 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-27 14:27 rohitarulraj
2015-04-28 10:06 ` rohitarulraj
2015-04-28 18:37 ` Jeff Law
2015-04-28 18:46 ` rohitarulraj
2015-04-28 22:46 ` Jeff Law
2015-04-29 10:43 ` rohitarulraj
2015-04-30 15:15 ` Jeff Law [this message]
2015-04-30 15:44 ` rohitarulraj
2015-04-30 15:55 ` Jeff Law
2015-05-05 7:59 ` rohitarulraj
2015-05-15 5:01 ` Jeff Law
2015-05-15 10:38 ` Dharmakan Rohit Arul Raj
2015-05-15 17:53 ` Jeff Law
2015-05-18 8:00 ` Richard Biener
2015-05-25 8:21 ` Dharmakan Rohit Arul Raj
2015-05-26 8:49 ` Richard Biener
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=554243E9.6030206@redhat.com \
--to=law@redhat.com \
--cc=amodra@gmail.com \
--cc=dje.gcc@gmail.com \
--cc=edmar@freescale.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jakub@redhat.com \
--cc=rguenther@suse.de \
--cc=rohitarulraj@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).