From: Kwok Cheung Yeung <kcy@codesourcery.com>
To: Bin.Cheng <amker.cheng@gmail.com>, <ramrad01@arm.com>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH] Fix for PR26702: Emit .size for BSS variables on arm-eabi
Date: Thu, 30 Apr 2015 16:56:00 -0000 [thread overview]
Message-ID: <55425803.5060102@codesourcery.com> (raw)
In-Reply-To: <CAHFci2-SRokhL24M4bPyzs=_1w4=u044uuNVMSMsO-RcGYV==w@mail.gmail.com>
Hello
The target of the pr26702.c testcase was changed while committing from:
{ target arm*-*-eabi* }
in my original patch to:
{ target arm_eabi }
The check_effective_target_arm_eabi test (in
gcc/testsuite/lib/target-supports.exp) checks for the presence of the
__ARM_EABI__ preprocessor define, which is also present for the
arm-none-linux-gnueabi* targets. This test should only be run on
bare-metal targets without an OS, so this change was incorrect.
Ramana, could you please revert the target string to what it was originally?
Thanks
Kwok
ChangeLog (gcc/testsuite/):
* gcc.target/arm/pr26702.c: Change target to run only on
bare-metal configs.
On 30/04/2015 8:13 AM, Bin.Cheng wrote:
> Hi Kwok,
> The newly introduced test case failed on
> arm-none-linux-gnueabi&arm-none-linux-gnueabihf. Could you please
> have a look at it?
>
> FAIL: gcc.target/arm/pr26702.c scan-assembler \\.size[\\t ]+static_foo, 4
>
> PR65937 is filed for tracking this.
>
> Thanks,
> bin
>
prev parent reply other threads:[~2015-04-30 16:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-30 20:25 Kwok Cheung Yeung
2015-04-23 14:51 ` Ramana Radhakrishnan
2015-04-30 7:19 ` Bin.Cheng
2015-04-30 16:56 ` Kwok Cheung Yeung [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55425803.5060102@codesourcery.com \
--to=kcy@codesourcery.com \
--cc=amker.cheng@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=ramrad01@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).