From: Kyrill Tkachov <kyrylo.tkachov@arm.com>
To: GCC Patches <gcc-patches@gcc.gnu.org>
Cc: Marcus Shawcroft <marcus.shawcroft@arm.com>,
Richard Earnshaw <Richard.Earnshaw@arm.com>,
James Greenhalgh <james.greenhalgh@arm.com>
Subject: [PATCH][AArch64] Do not overwrite cost in bswap case
Date: Fri, 01 May 2015 08:25:00 -0000 [thread overview]
Message-ID: <55433884.4030800@arm.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 450 bytes --]
Hi all,
This patch is trivial. We already initialise the cost to COSTS_N_INSNS (1) at the top of the function.
No need to overwrite it again. Just add the cost of a rev and recurse into the operands.
Bootstrapped and tested on aarch64-linux.
Ok for trunk?
Thanks,
Kyrill
2015-05-01 Kyrylo Tkachov <kyrylo.tkachov@arm.com>
* config/aarch64/aarch64.c (aarch64_rtx_costs): Do not overwrite cost
with COSTS_N_INSNS (1).
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: aarch64-costs-bswap-op.patch --]
[-- Type: text/x-patch; name=aarch64-costs-bswap-op.patch, Size: 561 bytes --]
commit 30857e8a8ff816244c49b3c76b6044c1d5cc9f2f
Author: Kyrylo Tkachov <kyrylo.tkachov@arm.com>
Date: Tue Mar 3 10:10:53 2015 +0000
[AArch64] Do not overwrite BSWAP rtx cost, let recursion handle the operand
diff --git a/gcc/config/aarch64/aarch64.c b/gcc/config/aarch64/aarch64.c
index 6083fd4..e19b592 100644
--- a/gcc/config/aarch64/aarch64.c
+++ b/gcc/config/aarch64/aarch64.c
@@ -5995,7 +5995,6 @@ cost_plus:
}
case BSWAP:
- *cost = COSTS_N_INSNS (1);
if (speed)
*cost += extra_cost->alu.rev;
next reply other threads:[~2015-05-01 8:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-01 8:25 Kyrill Tkachov [this message]
2015-05-01 8:42 ` Marcus Shawcroft
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55433884.4030800@arm.com \
--to=kyrylo.tkachov@arm.com \
--cc=Richard.Earnshaw@arm.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=james.greenhalgh@arm.com \
--cc=marcus.shawcroft@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).