From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 75326 invoked by alias); 1 May 2015 13:20:10 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 75313 invoked by uid 89); 1 May 2015 13:20:09 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.2 X-HELO: eu-smtp-delivery-143.mimecast.com Received: from eu-smtp-delivery-143.mimecast.com (HELO eu-smtp-delivery-143.mimecast.com) (146.101.78.143) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 01 May 2015 13:20:08 +0000 Received: from cam-owa1.Emea.Arm.com (fw-tnat.cambridge.arm.com [217.140.96.140]) by uk-mta-7.uk.mimecast.lan; Fri, 01 May 2015 14:20:05 +0100 Received: from [10.2.207.50] ([10.1.2.79]) by cam-owa1.Emea.Arm.com with Microsoft SMTPSVC(6.0.3790.3959); Fri, 1 May 2015 14:20:05 +0100 Message-ID: <55437D85.1070405@arm.com> Date: Fri, 01 May 2015 13:20:00 -0000 From: Kyrill Tkachov User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0 MIME-Version: 1.0 To: Wilco Dijkstra CC: GCC Patches Subject: Re: [PATCH][AArch64] Make aarch64_min_divisions_for_recip_mul configurable References: <000401d080f0$16a78c90$43f6a5b0$@com> <000001d08401$abe1a570$03a4f050$@com> <000501d08410$63f46a90$2bdd3fb0$@com> In-Reply-To: <000501d08410$63f46a90$2bdd3fb0$@com> X-MC-Unique: ZCOcJEfZSO6sKJ_KamqXkA-1 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2015-05/txt/msg00047.txt.bz2 On 01/05/15 14:11, Wilco Dijkstra wrote: >> Marcus Shawcroft wrote: >> On 1 May 2015 at 12:26, Wilco Dijkstra wrote: >>> >>>> Marcus Shawcroft wrote: >>>> On 27 April 2015 at 14:43, Wilco Dijkstra wrote: >>>> >>>>>> static unsigned int >>>>>> -aarch64_min_divisions_for_recip_mul (enum machine_mode mode ATTRIBU= TE_UNUSED) >>>>>> +aarch64_min_divisions_for_recip_mul (enum machine_mode mode) >>>>>> { >>>>>> - return 2; >>>>>> + if (GET_MODE_UNIT_SIZE (mode) =3D=3D 4) >>>>>> + return aarch64_tune_params->min_div_recip_mul_sf; >>>>>> + return aarch64_tune_params->min_div_recip_mul_df; >>>> This should be expressed directly as mode =3D=3D SFmode (or DFmode) ra= ther >>>> than the indirect approach of first computing the size first. >>> Can we never see vector types at this point? >> Fair point, curiously we don't appear to see them, but I see no reason >> why we should not. Commit your patch as proposed. >> >> Cheers /Marcus > And this one please. Done with r222679. Kyrill > > Wilco > > 2015-05-01 Wilco Dijkstra > > * gcc/config/aarch64/aarch64-protos.h (tune_params): > Add min_div_recip_mul_sf and min_div_recip_mul_df fields. > * gcc/config/aarch64/aarch64.c (aarch64_min_divisions_for_recip_mul): > Return value depending on target. > (generic_tunings): Initialize new target settings. > (cortexa53_tunings): Likewise. > (cortexa57_tunings): Likewise. > (thunderx_tunings): Likewise. > (xgene1_tunings): Likewise. >