From: Kyrill Tkachov <kyrylo.tkachov@arm.com>
To: Sandra Loosemore <sandra@codesourcery.com>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>,
"gerald@pfeifer.com" <gerald@pfeifer.com>
Subject: Re: [PATCH][doc] Update definition location of attribute_spec in documentation
Date: Fri, 01 May 2015 15:34:00 -0000 [thread overview]
Message-ID: <55439CE7.8000108@arm.com> (raw)
In-Reply-To: <55439A34.6050707@codesourcery.com>
On 01/05/15 16:22, Sandra Loosemore wrote:
> On 05/01/2015 08:51 AM, Kyrill Tkachov wrote:
>> Hi all,
>>
>> Like the subject says, struct attribute_spec is now defined in
>> tree-core.h rather than tree.h.
>> The patch updates the reference that I spotted.
>>
>> Ok for trunk?
>>
>> Thanks,
>> Kyrill
>>
>> 2015-05-01 Kyrylo Tkachov <kyrylo.tkachov@arm.com>
>>
>> * target.def (attribute_table): Mention that struct attribute_spec
>> is defined in tree-core.h rather than tree.h
>> * doc/tm.texi: Regenerate.
> This looks fine to me. In fact, I think this sort of change qualifies
> as obvious and can just be committed without asking for review.
Thanks, I agree that the content is obvious.
It's just that I always get confused whenever I modify target.def
because on building the documentation it errors out and demands that
I manually copy the tm.texi from the build back to the sources so I
just wanted to make sure that the patch can just be applied as is.
Kyrill
>
> -Sandra
>
next prev parent reply other threads:[~2015-05-01 15:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-01 14:51 Kyrill Tkachov
2015-05-01 15:23 ` Sandra Loosemore
2015-05-01 15:34 ` Kyrill Tkachov [this message]
2015-05-01 16:09 ` Jeff Law
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55439CE7.8000108@arm.com \
--to=kyrylo.tkachov@arm.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=gerald@pfeifer.com \
--cc=sandra@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).