public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
* [PATCH][doc] Update definition location of attribute_spec in documentation
@ 2015-05-01 14:51 Kyrill Tkachov
  2015-05-01 15:23 ` Sandra Loosemore
  2015-05-01 16:09 ` Jeff Law
  0 siblings, 2 replies; 4+ messages in thread
From: Kyrill Tkachov @ 2015-05-01 14:51 UTC (permalink / raw)
  To: GCC Patches; +Cc: Sandra Loosemore, gerald

[-- Attachment #1: Type: text/plain, Size: 407 bytes --]

Hi all,

Like the subject says, struct attribute_spec is now defined in tree-core.h rather than tree.h.
The patch updates the reference that I spotted.

Ok for trunk?

Thanks,
Kyrill

2015-05-01  Kyrylo Tkachov  <kyrylo.tkachov@arm.com>

     * target.def (attribute_table): Mention that struct attribute_spec
     is defined in tree-core.h rather than tree.h
     * doc/tm.texi: Regenerate.

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: doc-attr-table.patch --]
[-- Type: text/x-patch; name=doc-attr-table.patch, Size: 1199 bytes --]

diff --git a/gcc/doc/tm.texi b/gcc/doc/tm.texi
index f85ccec..e07f59c 100644
--- a/gcc/doc/tm.texi
+++ b/gcc/doc/tm.texi
@@ -9828,7 +9828,7 @@ be documented in @file{extend.texi}.
 
 @deftypevr {Target Hook} {const struct attribute_spec *} TARGET_ATTRIBUTE_TABLE
 If defined, this target hook points to an array of @samp{struct
-attribute_spec} (defined in @file{tree.h}) specifying the machine
+attribute_spec} (defined in @file{tree-core.h}) specifying the machine
 specific attributes for this target and some of the restrictions on the
 entities to which these attributes are applied and the arguments they
 take.
diff --git a/gcc/target.def b/gcc/target.def
index 842ebf7..3ea4c8a 100644
--- a/gcc/target.def
+++ b/gcc/target.def
@@ -1980,7 +1980,7 @@ merging.",
 DEFHOOKPOD
 (attribute_table,
  "If defined, this target hook points to an array of @samp{struct\n\
-attribute_spec} (defined in @file{tree.h}) specifying the machine\n\
+attribute_spec} (defined in @file{tree-core.h}) specifying the machine\n\
 specific attributes for this target and some of the restrictions on the\n\
 entities to which these attributes are applied and the arguments they\n\
 take.",

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH][doc] Update definition location of attribute_spec in documentation
  2015-05-01 14:51 [PATCH][doc] Update definition location of attribute_spec in documentation Kyrill Tkachov
@ 2015-05-01 15:23 ` Sandra Loosemore
  2015-05-01 15:34   ` Kyrill Tkachov
  2015-05-01 16:09 ` Jeff Law
  1 sibling, 1 reply; 4+ messages in thread
From: Sandra Loosemore @ 2015-05-01 15:23 UTC (permalink / raw)
  To: Kyrill Tkachov; +Cc: GCC Patches, gerald

On 05/01/2015 08:51 AM, Kyrill Tkachov wrote:
> Hi all,
>
> Like the subject says, struct attribute_spec is now defined in
> tree-core.h rather than tree.h.
> The patch updates the reference that I spotted.
>
> Ok for trunk?
>
> Thanks,
> Kyrill
>
> 2015-05-01  Kyrylo Tkachov  <kyrylo.tkachov@arm.com>
>
>      * target.def (attribute_table): Mention that struct attribute_spec
>      is defined in tree-core.h rather than tree.h
>      * doc/tm.texi: Regenerate.

This looks fine to me.  In fact, I think this sort of change qualifies 
as obvious and can just be committed without asking for review.

-Sandra

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH][doc] Update definition location of attribute_spec in documentation
  2015-05-01 15:23 ` Sandra Loosemore
@ 2015-05-01 15:34   ` Kyrill Tkachov
  0 siblings, 0 replies; 4+ messages in thread
From: Kyrill Tkachov @ 2015-05-01 15:34 UTC (permalink / raw)
  To: Sandra Loosemore; +Cc: GCC Patches, gerald


On 01/05/15 16:22, Sandra Loosemore wrote:
> On 05/01/2015 08:51 AM, Kyrill Tkachov wrote:
>> Hi all,
>>
>> Like the subject says, struct attribute_spec is now defined in
>> tree-core.h rather than tree.h.
>> The patch updates the reference that I spotted.
>>
>> Ok for trunk?
>>
>> Thanks,
>> Kyrill
>>
>> 2015-05-01  Kyrylo Tkachov  <kyrylo.tkachov@arm.com>
>>
>>       * target.def (attribute_table): Mention that struct attribute_spec
>>       is defined in tree-core.h rather than tree.h
>>       * doc/tm.texi: Regenerate.
> This looks fine to me.  In fact, I think this sort of change qualifies
> as obvious and can just be committed without asking for review.

Thanks, I agree that the content is obvious.
It's just that I always get confused whenever I modify target.def
because on building the documentation it errors out and demands that
I manually copy the tm.texi from the build back to the sources so I
just wanted to make sure that the patch can just be applied as is.

Kyrill

>
> -Sandra
>

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH][doc] Update definition location of attribute_spec in documentation
  2015-05-01 14:51 [PATCH][doc] Update definition location of attribute_spec in documentation Kyrill Tkachov
  2015-05-01 15:23 ` Sandra Loosemore
@ 2015-05-01 16:09 ` Jeff Law
  1 sibling, 0 replies; 4+ messages in thread
From: Jeff Law @ 2015-05-01 16:09 UTC (permalink / raw)
  To: Kyrill Tkachov, GCC Patches; +Cc: Sandra Loosemore, gerald

On 05/01/2015 08:51 AM, Kyrill Tkachov wrote:
> Hi all,
>
> Like the subject says, struct attribute_spec is now defined in
> tree-core.h rather than tree.h.
> The patch updates the reference that I spotted.
>
> Ok for trunk?
>
> Thanks,
> Kyrill
>
> 2015-05-01  Kyrylo Tkachov  <kyrylo.tkachov@arm.com>
>
>      * target.def (attribute_table): Mention that struct attribute_spec
>      is defined in tree-core.h rather than tree.h
>      * doc/tm.texi: Regenerate.
OK.
jeff

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2015-05-01 16:09 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-05-01 14:51 [PATCH][doc] Update definition location of attribute_spec in documentation Kyrill Tkachov
2015-05-01 15:23 ` Sandra Loosemore
2015-05-01 15:34   ` Kyrill Tkachov
2015-05-01 16:09 ` Jeff Law

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).