From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 61358 invoked by alias); 2 May 2015 12:50:22 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 61334 invoked by uid 89); 2 May 2015 12:50:21 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-Spam-User: qpsmtpd, 2 recipients X-HELO: vms173011pub.verizon.net Received: from vms173011pub.verizon.net (HELO vms173011pub.verizon.net) (206.46.173.11) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Sat, 02 May 2015 12:50:20 +0000 MIME-version: 1.0 Content-transfer-encoding: 8BIT Content-type: text/plain; charset=utf-8; format=flowed Received: from [192.168.1.3] ([173.67.5.214]) by vms173011.mailsrvcs.net (Oracle Communications Messaging Server 7.0.5.32.0 64bit (built Jul 16 2014)) with ESMTPA id <0NNQ0040S3N92J00@vms173011.mailsrvcs.net>; Sat, 02 May 2015 07:50:03 -0500 (CDT) X-CMAE-Score: 0 X-CMAE-Analysis: v=2.1 cv=Ap5ZB14n c=1 sm=1 tr=0 a=EgxZNPMZQWYqNIP3PIRi2A==:117 a=FurB0epzNeMA:10 a=IkcTkHD0fZMA:10 a=o1OHuDzbAAAA:8 a=oR5dmqMzAAAA:8 a=hTZS6uLwhHpx5LOQAS/v3KalXBI=:19 a=-9mUelKeXuEA:10 a=h1PgugrvaO0A:10 a=ZudfLCK7vIb400JN1sUA:9 a=QEXdDO2ut3YA:10 Message-id: <5544C7F5.2080305@verizon.net> Date: Sat, 02 May 2015 12:50:00 -0000 From: Ed Smith-Rowland <3dw4rd@verizon.net> User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 To: Jonathan Wakely Cc: Ville Voutilainen , "gcc-patches@gcc.gnu.org" , libstdc++@gcc.gnu.org Subject: Re: [libstdc++ PATCH] Implement observer_ptr References: <20150501210123.GN3618@redhat.com> <5544303A.3010607@verizon.net> <20150502094002.GQ3618@redhat.com> <20150502094224.GR3618@redhat.com> In-reply-to: <20150502094224.GR3618@redhat.com> X-SW-Source: 2015-05/txt/msg00132.txt.bz2 On 05/02/2015 05:42 AM, Jonathan Wakely wrote: > On 02/05/15 10:40 +0100, Jonathan Wakely wrote: >> On 01/05/15 22:02 -0400, Ed Smith-Rowland wrote: >>> On 05/01/2015 05:01 PM, Jonathan Wakely wrote: >>>> On 01/05/15 16:37 +0300, Ville Voutilainen wrote: >>>>> Tested on Linux-x64. >>>>> >>>>> Implement observer_ptr. >>>> >>>> Thanks! Committed with some minor formatting changes. >>>> >>>> I've also committed this to add feature-test macros and update the >>>> docs. Tested powerpc64le-linux, committed to trunk. >>>> >>>> >>> I pretty sure we're supposed to add the macro for *all* the headers >>> that got enable_if. >> >> That's not how I read the Fundamentals TS: >> >> Programmers who wish to determine whether a feature is available in >> an implementation should base that determination on the presence of >> the header (determined with __has_include(
)) and the >> state of the macro with the recommended name. >> >> And the header for erase_if is listed as . > > > And SD-6 says: > > For library features, the “Header“ column identifies the header that > is expected to define the macro, although the macro may also be > predefined. > > > OK. Thanks. I do remember an SD-6 discussion about how annoying the define-the-macro-in-all-relevant-headers was. I didn't know there was a resolution. I need to reeducate myself. Meanwhile I'll rollback my patch. Reverted in 222722. I'll ask next time. Sorry for the noise. Ed