From: Jeff Law <law@redhat.com>
To: David Malcolm <dmalcolm@redhat.com>, gcc-patches@gcc.gnu.org
Subject: Re: [PATCH 1/4] libcpp: Improvements to comments in line-map.h/c
Date: Mon, 04 May 2015 17:18:00 -0000 [thread overview]
Message-ID: <5547A9E6.9070508@redhat.com> (raw)
In-Reply-To: <1430528215-19648-2-git-send-email-dmalcolm@redhat.com>
On 05/01/2015 06:56 PM, David Malcolm wrote:
> This patch updates and expands some comments in libcpp, adding
> a big table to try to clarify what an individual source_location
> value can mean.
>
> libcpp/ChangeLog:
> * include/line-map.h: Fix comment at the top of the file.
> (source_location): Rewrite and expand the comment for this
> typedef, adding an ascii-art table to clarify how source_location
> values are allocated.
> * line-map.c: Fix comment at the top of the file.
OK.
jeff
prev parent reply other threads:[~2015-05-04 17:18 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-02 0:44 [PATCH 0/4] libcpp patches David Malcolm
2015-05-02 0:44 ` [PATCH 3/4] libcpp/input.c: Add a way to visualize the linemaps David Malcolm
2015-05-04 19:20 ` Jeff Law
2015-05-13 14:05 ` David Malcolm
2015-05-02 0:44 ` [PATCH 4/4] Replace line_map union with C++ class hierarchy David Malcolm
2015-05-04 20:45 ` Jeff Law
2015-05-04 21:34 ` David Malcolm
2015-05-14 15:20 ` Jeff Law
2015-05-02 0:44 ` [PATCH 2/4] libcpp: Replace macro usage with C++ constructs David Malcolm
2015-05-04 19:15 ` Jeff Law
2015-05-05 18:08 ` [PATCH 2/4 v2] libcpp: Replace macro usage with C++ constructs) David Malcolm
2015-05-05 18:08 ` [PATCH 5/4] libcpp: Eliminate most of the non-const/reference-returning inline fns David Malcolm
2015-05-08 21:49 ` Jeff Law
2015-05-05 18:08 ` [PATCH 2/4 v2: part 1] Move linemap_assert higher up within the file David Malcolm
2015-05-08 21:35 ` Jeff Law
2015-05-05 18:08 ` [PATCH 2/4 v2: part 2] libcpp: Replace macro usage with C++ constructs David Malcolm
2015-05-08 21:47 ` Jeff Law
2015-07-08 14:50 ` Thomas Schwinge
2015-07-08 15:14 ` David Malcolm
2015-05-08 21:45 ` [PATCH 2/4 v2] libcpp: Replace macro usage with C++ constructs) Jeff Law
2015-05-10 15:39 ` Jan Hubicka
2015-05-02 0:44 ` [PATCH 1/4] libcpp: Improvements to comments in line-map.h/c David Malcolm
2015-05-04 17:18 ` Jeff Law [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5547A9E6.9070508@redhat.com \
--to=law@redhat.com \
--cc=dmalcolm@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).