From: Jeff Law <law@redhat.com>
To: Jakub Jelinek <jakub@redhat.com>, Richard Biener <rguenther@suse.de>
Cc: gcc-patches@gcc.gnu.org
Subject: Re: [PATCH] Fix ubsan non-call-exceptions ICE (PR tree-optimization/65984)
Date: Mon, 04 May 2015 19:43:00 -0000 [thread overview]
Message-ID: <5547CBCD.809@redhat.com> (raw)
In-Reply-To: <20150504181640.GF1751@tucnak.redhat.com>
On 05/04/2015 12:16 PM, Jakub Jelinek wrote:
> Hi!
>
> The code I've added in r217755 was assuming that stmt_could_throw_p
> memory read will always end a bb, but that is clearly not the case.
> Thus, the following patch uses stmt_ends_bb_p instead.
>
> Bootstrapped/regtested on x86_64-linux and i686-linux, ok for trunk/5?
>
> 2015-05-04 Jakub Jelinek <jakub@redhat.com>
>
> PR tree-optimization/65984
> * ubsan.c: Include tree-cfg.h.
> (instrument_bool_enum_load): Use stmt_ends_bb_p instead of
> stmt_could_throw_p test, rename can_throw variable to ends_bb.
>
> * c-c++-common/ubsan/pr65984.c: New test.
OK.
Jeff
prev parent reply other threads:[~2015-05-04 19:43 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-04 18:16 Jakub Jelinek
2015-05-04 19:43 ` Jeff Law [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5547CBCD.809@redhat.com \
--to=law@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jakub@redhat.com \
--cc=rguenther@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).