From: Mikhail Maltsev <maltsevm@gmail.com>
To: gcc-patches <gcc-patches@gnu.org>, Jeff Law <law@redhat.com>
Subject: Re: [PATCH, RFC]: Next stage1, refactoring: propagating rtx subclasses
Date: Mon, 04 May 2015 20:32:00 -0000 [thread overview]
Message-ID: <5547D766.5090806@gmail.com> (raw)
In-Reply-To: <5541B6D1.7030502@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 1629 bytes --]
(the original message was bounced by the mailing list, resending with
compressed attachment)
On 30.04.2015 8:00, Jeff Law wrote:
>
> Can you please check the changes to do_jump_1, the indention looked
> weird in the patch. If it's correct, just say so.
It is ok. Probably that's because the surrounding code is indented with
spaces.
> The definition of PEEP2_EOB looks wrong. I don't see how you can
> safely cast pc_rtx to an rtx_insn * since it's an RTX rather than rtx
> chain object. Maybe you're getting away with it because it's used as
> marker. But it still feels wrong.
Yes, FWIW, it is only needed for assertions in peep2_regno_dead_p and
peep2_reg_dead_p which check it against NULL (they are intended to
verify that live_before field in peep2_insn_data struct is valid). At
least, when I removed the assertions and changed PEEP2_EOB to NULL (as
an experiment), the testsuite passed without regressions.
> You'd probably be better off creating a unique rtx_insn * object and
> using that as the marker.
OK. Fixed the patch. Rebased and tested on x86_64-linux (fortunately, it
did not conflict with Trevor's series of rtx_insn-related patches).
I'm trying to continue and the next patch (peep_split.patch,
peep_split.cl) is addressing the same task in some of the generated code
(namely, gen_peephole2_* and gen_split_* series of functions).
> If you're going to continue this work, you should probably get
> write-after-approval access so that you can commit your own approved
> changes.
Is it OK to mention you as a maintainer who can approve my request for
write access?
--
Regards,
Mikhail Maltsev
[-- Attachment #2: as_insn.tar.gz --]
[-- Type: application/x-gzip, Size: 28642 bytes --]
next prev parent reply other threads:[~2015-05-04 20:32 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-31 4:38 Mikhail Maltsev
2015-03-31 15:52 ` Trevor Saunders
2015-04-02 21:13 ` Jeff Law
2015-04-25 11:49 ` Richard Sandiford
2015-04-27 16:38 ` Jeff Law
2015-04-27 16:57 ` Richard Sandiford
2015-04-27 20:01 ` Mikhail Maltsev
2015-04-28 13:50 ` Richard Sandiford
2015-04-28 17:12 ` Jeff Law
2015-04-29 8:02 ` Mikhail Maltsev
2015-04-30 3:54 ` Jeff Law
2015-04-30 5:46 ` Jeff Law
2015-05-04 20:32 ` Mikhail Maltsev [this message]
2015-05-04 21:22 ` Trevor Saunders
2015-05-09 5:49 ` Trevor Saunders
[not found] ` <5547D40F.6010802@gmail.com>
2015-05-08 21:54 ` Jeff Law
2015-05-11 20:41 ` Mikhail Maltsev
2015-05-11 21:21 ` Joseph Myers
2015-05-12 20:26 ` Jeff Law
2015-06-06 5:51 ` Mikhail Maltsev
2015-04-28 23:55 ` Jeff Law
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5547D766.5090806@gmail.com \
--to=maltsevm@gmail.com \
--cc=gcc-patches@gnu.org \
--cc=law@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).