From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 102272 invoked by alias); 5 May 2015 09:15:32 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 102241 invoked by uid 89); 5 May 2015 09:15:29 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.3 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: relay1.mentorg.com Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 05 May 2015 09:15:19 +0000 Received: from nat-ies.mentorg.com ([192.94.31.2] helo=SVR-IES-FEM-01.mgc.mentorg.com) by relay1.mentorg.com with esmtp id 1YpYwd-0001Vk-G9 from Tom_deVries@mentor.com for gcc-patches@gcc.gnu.org; Tue, 05 May 2015 02:15:15 -0700 Received: from [127.0.0.1] (137.202.0.76) by SVR-IES-FEM-01.mgc.mentorg.com (137.202.0.104) with Microsoft SMTP Server id 14.3.224.2; Tue, 5 May 2015 10:15:13 +0100 Message-ID: <55488A1F.4050307@mentor.com> Date: Tue, 05 May 2015 09:15:00 -0000 From: Tom de Vries User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: GCC Patches Subject: [PATCH,testsuite] Xfail gcc.dg/tree-ssa/stdarg-2.c f15 scans Content-Type: multipart/mixed; boundary="------------070505000800010803040402" X-SW-Source: 2015-05/txt/msg00294.txt.bz2 --------------070505000800010803040402 Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit Content-length: 1708 Hi, after checking in the 'postpone expanding va_arg till pass_stdarg' patch series, some scans related to function f15 in gcc.dg/tree-ssa/stdarg-2.c have started failing. [ The committed patch series contained a modification of stdarg-2.c, but that seems to be not complete and not correct. ] F.i., for s390 we find at https://gcc.gnu.org/ml/gcc-testresults/2015-05/msg00507.html: ... FAIL: gcc.dg/tree-ssa/stdarg-2.c scan-tree-dump stdarg "f15: va_list escapes 0, needs to save 1 GPR units and 2 FPR units" ... Furthermore, at https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64950#c11 it was noted that: ... Unfortunately, the gcc.dg/tree-ssa/stdarg-2.c part of the patch is wrong: the test now FAILs on i686-unknown-linux-gnu, i686-apple-darwin, and i386-pc-solaris with -m64: both dumps (i.e. -m32 and -m64) contain m32/stdarg-2.c.084t.stdarg:f15: va_list escapes 1, needs to save all GPR units and all FPR units. m64/stdarg-2.c.084t.stdarg:f15: va_list escapes 1, needs to save all GPR units and all FPR units. ... I've filed two PRs: - PR66010 '[6 Regression] Missed optimization after inlining va_list parameter' https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66010 - PR66013 'Missed optimization after inlining va_list parameter, -m32 case' https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66013 to track these errors. AFAIU now from the investigations in those PRs, we can expect all f15 scans that check for the presence of 'va_list escapes 0' to fail. I'd like to commit two patches. - The first patch undoes the modification of stdarg-2.c as committed in the original patch series (omitted). - The second patch adds appropriate xfails (attached). OK for trunk? Thanks, - Tom --------------070505000800010803040402 Content-Type: text/x-patch; name="0002-Xfail-gcc.dg-tree-ssa-stdarg-2.c-f15-scans.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="0002-Xfail-gcc.dg-tree-ssa-stdarg-2.c-f15-scans.patch" Content-length: 2518 [PATCH 2/2] Xfail gcc.dg/tree-ssa/stdarg-2.c f15 scans 2015-05-05 Tom de Vries * gcc.dg/tree-ssa/stdarg-2.c: Xfail f15 scans which test for presence of 'va_list escapes 0'. --- gcc/testsuite/gcc.dg/tree-ssa/stdarg-2.c | 14 +++++++++++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/gcc/testsuite/gcc.dg/tree-ssa/stdarg-2.c b/gcc/testsuite/gcc.dg/tree-ssa/stdarg-2.c index fe39da3..f09b5de 100644 --- a/gcc/testsuite/gcc.dg/tree-ssa/stdarg-2.c +++ b/gcc/testsuite/gcc.dg/tree-ssa/stdarg-2.c @@ -288,10 +288,18 @@ f15 (int i, ...) f15_1 (ap); va_end (ap); } -/* { dg-final { scan-tree-dump "f15: va_list escapes 0, needs to save \[148\] GPR units and \[1-9\]\[0-9\]* FPR units" "stdarg" { target { { i?86-*-* x86_64-*-* } && { ! { ia32 || llp64 } } } } } } */ -/* { dg-final { scan-tree-dump "f15: va_list escapes 0, needs to save \[148\] GPR units and \[1-9\]\[0-9\]* FPR units" "stdarg" { target { powerpc*-*-linux* && { powerpc_fprs && ilp32 } } } } } */ + +/* Following three dg-finals are marked as xfail due to PR66010/PR66013. */ +/* Was: { target { { i?86-*-* x86_64-*-* } && { ! { ia32 || llp64 } } } }. */ +/* { dg-final { scan-tree-dump "f15: va_list escapes 0, needs to save \[148\] GPR units and \[1-9\]\[0-9\]* FPR units" "stdarg" { xfail *-*-* } } } */ +/* Was: { target { powerpc*-*-linux* && { powerpc_fprs && ilp32 } } }. */ +/* { dg-final { scan-tree-dump "f15: va_list escapes 0, needs to save \[148\] GPR units and \[1-9\]\[0-9\]* FPR units" "stdarg" { xfail *-*-* } } } */ +/* Was: { target s390*-*-linux* }. */ +/* { dg-final { scan-tree-dump "f15: va_list escapes 0, needs to save 1 GPR units and 2 FPR units" "stdarg" { xfail *-*-* } } } */ + +/* We may be able to improve upon this after fixing PR66010/PR66013. */ /* { dg-final { scan-tree-dump "f15: va_list escapes 1, needs to save all GPR units and all FPR units" "stdarg" { target alpha*-*-linux* } } } */ -/* { dg-final { scan-tree-dump "f15: va_list escapes 0, needs to save 1 GPR units and 2 FPR units" "stdarg" { target s390*-*-linux* } } } */ + /* { dg-final { scan-tree-dump-not "f15: va_list escapes 0, needs to save 0 GPR units" "stdarg" { target { { i?86-*-* x86_64-*-* } && ia32 } } } } */ /* { dg-final { scan-tree-dump-not "f15: va_list escapes 0, needs to save 0 GPR units" "stdarg" { target ia64-*-* } } } */ /* { dg-final { scan-tree-dump-not "f15: va_list escapes 0, needs to save 0 GPR units" "stdarg" { target { powerpc*-*-* && lp64 } } } } */ -- 1.9.1 --------------070505000800010803040402--