From: Aldy Hernandez <aldyh@redhat.com>
To: Eric Botcazou <ebotcazou@adacore.com>
Cc: gcc-patches@gcc.gnu.org
Subject: Re: [patch 1/10] debug-early merge: Ada front-end
Date: Fri, 08 May 2015 16:23:00 -0000 [thread overview]
Message-ID: <554CE2E0.8050308@redhat.com> (raw)
In-Reply-To: <6819186.gzK1HFtdtl@polaris>
On 05/08/2015 03:26 AM, Eric Botcazou wrote:
>> @@ -5204,28 +5199,6 @@ gnat_write_global_declarations (void)
>> types_used_by_var_decl_insert (t, dummy_global);
>> }
>> }
>> -
>> - /* Output debug information for all global type declarations first. This
>> - ensures that global types whose compilation hasn't been finalized
>> yet, - for example pointers to Taft amendment types, have their
>> compilation - finalized in the right context. */
>> - FOR_EACH_VEC_SAFE_ELT (global_decls, i, iter)
>> - if (TREE_CODE (iter) == TYPE_DECL && !DECL_IGNORED_P (iter))
>> - debug_hooks->global_decl (iter);
>> -
>> - /* Proceed to optimize and emit assembly. */
>> - symtab->finalize_compilation_unit ();
>> -
>> - /* After cgraph has had a chance to emit everything that's going to
>> - be emitted, output debug information for the rest of globals. */
>> - if (!seen_error ())
>> - {
>> - timevar_push (TV_SYMOUT);
>> - FOR_EACH_VEC_SAFE_ELT (global_decls, i, iter)
>> - if (TREE_CODE (iter) != TYPE_DECL && !DECL_IGNORED_P (iter))
>> - debug_hooks->global_decl (iter);
>> - timevar_pop (TV_SYMOUT);
>> - }
>> }
>
> What's the replacement mechanism for the first pass on global_decls? The
> comment explains that generating debug info must be delayed in this case.
>
Ah, I see what you mean. I'll address this and repost.
Thanks.
Aldy
next prev parent reply other threads:[~2015-05-08 16:23 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-08 0:32 Aldy Hernandez
2015-05-08 10:27 ` Eric Botcazou
2015-05-08 10:35 ` Richard Biener
2015-05-08 15:22 ` Aldy Hernandez
2015-05-09 11:31 ` Eric Botcazou
2015-05-08 16:23 ` Aldy Hernandez [this message]
2015-05-09 11:31 ` Eric Botcazou
2015-05-21 21:33 ` Aldy Hernandez
2015-05-22 8:52 ` Eric Botcazou
2015-05-22 12:33 ` Aldy Hernandez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=554CE2E0.8050308@redhat.com \
--to=aldyh@redhat.com \
--cc=ebotcazou@adacore.com \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).