From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9167 invoked by alias); 11 May 2015 04:10:01 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 9151 invoked by uid 89); 11 May 2015 04:10:00 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Mon, 11 May 2015 04:09:56 +0000 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t4B49rK0031467 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Mon, 11 May 2015 00:09:54 -0400 Received: from localhost.localdomain (ovpn-113-143.phx2.redhat.com [10.3.113.143]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t4B49pRc017009; Mon, 11 May 2015 00:09:51 -0400 Message-ID: <55502B8E.7010907@redhat.com> Date: Mon, 11 May 2015 04:10:00 -0000 From: Jeff Law User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Segher Boessenkool , gcc-patches@gcc.gnu.org CC: dje.gcc@gmail.com Subject: Re: [PATCH 1/6] combine: undo_to_marker References: <705755bdc5ee76e41032f7b490d134ce88f9256e.1431268135.git.segher@kernel.crashing.org> In-Reply-To: <705755bdc5ee76e41032f7b490d134ce88f9256e.1431268135.git.segher@kernel.crashing.org> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2015-05/txt/msg00878.txt.bz2 On 05/10/2015 10:13 AM, Segher Boessenkool wrote: > This generalises undo_all to allow undoing only the last some SUBSTs. > This is used by the next patch, but is more generally useful. > > Comments? > > > Segher > > > 2015-05-10 Segher Boessenkool > > * combine.c (get_undo_marker): New function. > (undo_to_marker): New function, largely factored out from ... > (undo_all): ... this. Adjust. Seems quite reasonable to me. I can't think of any reason offhand why it'd be a bad idea. jeff