public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Christian Bruel <christian.bruel@st.com>
To: Ramana Radhakrishnan <ramana.radhakrishnan@arm.com>,
	       "gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>,
	       Richard Earnshaw	<Richard.Earnshaw@arm.com>,
	       "nickc@redhat.com" <nickc@redhat.com>
Subject: Re: [PATCH, ARM] attribute target (thumb,arm) [1/6] respin (4th)
Date: Mon, 11 May 2015 09:14:00 -0000	[thread overview]
Message-ID: <555072D3.8070207@st.com> (raw)
In-Reply-To: <554B22BB.7080904@arm.com>

[-- Attachment #1: Type: text/plain, Size: 210 bytes --]

>
>
> OK with those changes.
>
>
>
> Ramana
>

thanks, done

following up the thumb_code cleanup, here is a missing chunk for the 
vxworks config.

arm-vxworks build checked. ok for trunk ?

thanks,

Christian

[-- Attachment #2: p1.1.patch --]
[-- Type: text/x-patch, Size: 1218 bytes --]

 2015-05-11  Christian Bruel  <christian.bruel@st.com>
 
	* config/arm/arm-protos.h (thumb_code, thumb1_code): Remove.
	* config/arm/vxworks.h (thumb_code): Replace with TARGET_THUMB.

Index: gcc/config/arm/arm-protos.h
===================================================================
--- gcc/config/arm/arm-protos.h	(revision 222997)
+++ gcc/config/arm/arm-protos.h	(working copy)
@@ -462,12 +462,6 @@
 /* Nonzero if tuning for Cortex-A9.  */
 extern int arm_tune_cortex_a9;
 
-/* Nonzero if generating Thumb instructions.  */
-extern int thumb_code;
-
-/* Nonzero if generating Thumb-1 instructions.  */
-extern int thumb1_code;
-
 /* Nonzero if we should define __THUMB_INTERWORK__ in the
    preprocessor.
    XXX This is a bit of a hack, it's intended to help work around
Index: gcc/config/arm/vxworks.h
===================================================================
--- gcc/config/arm/vxworks.h	(revision 222997)
+++ gcc/config/arm/vxworks.h	(working copy)
@@ -40,7 +40,7 @@
       builtin_define ("CPU=ARMARCH5");		\
     else if (arm_arch4)				\
       {						\
-	if (thumb_code)				\
+	if (TARGET_THUMB)			\
 	  builtin_define ("CPU=ARMARCH4_T");	\
 	else					\
 	  builtin_define ("CPU=ARMARCH4");	\

  reply	other threads:[~2015-05-11  9:14 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-06 14:19 Christian Bruel
2015-05-07  8:30 ` Ramana Radhakrishnan
2015-05-11  9:14   ` Christian Bruel [this message]
2015-05-11  9:56     ` Ramana Radhakrishnan
2015-05-11 10:30       ` [PATCH, ARM] committed: " Christian Bruel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=555072D3.8070207@st.com \
    --to=christian.bruel@st.com \
    --cc=Richard.Earnshaw@arm.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=nickc@redhat.com \
    --cc=ramana.radhakrishnan@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).