From: Jeff Law <law@redhat.com>
To: Segher Boessenkool <segher@kernel.crashing.org>, gcc-patches@gcc.gnu.org
Cc: rth@redhat.com
Subject: Re: [PATCH] combine: Don't create (set (reg:CC) (compare (reg:CC) (const0)))
Date: Mon, 11 May 2015 17:23:00 -0000 [thread overview]
Message-ID: <5550E5A3.60305@redhat.com> (raw)
In-Reply-To: <c6ca02f333bffde49b8ec897b5b4acbd5cc0b475.1431349232.git.segher@kernel.crashing.org>
On 05/11/2015 07:13 AM, Segher Boessenkool wrote:
> There already was code to just use the original reg:CC, but it was
> positioned incorrectly: if the original code (that this RTL is
> simplified from) did not already start with a COMPARE (or not in
> the right mode), it didn't trigger. But it is valid in that case
> as well.
>
> This then allows merging the other two arms of this conditional;
> do so.
>
> Bootstrapped and regression tested on powerpc64-linux and x86_64-linux;
> no regressions. Also built toolchains and Linux kernels for every
> arch where that works; no new failures on that.
>
> Any objections?
>
>
> Segher
>
>
> 2015-05-11 Segher Boessenkool <segher@kernel.crashing.org>
>
> * combine.c (simplify_set): When generating a CC set, if the
> source already is in the correct mode, do not wrap it in a
> compare. Simplify the rest of that code.
Seems reasonable. Might not hurt to do a little testing on a cc0 target
though.
jeff
next prev parent reply other threads:[~2015-05-11 17:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-11 13:13 Segher Boessenkool
2015-05-11 17:23 ` Jeff Law [this message]
2015-05-11 21:11 ` Segher Boessenkool
2015-05-11 21:16 ` Jeff Law
2015-05-13 11:38 ` Segher Boessenkool
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5550E5A3.60305@redhat.com \
--to=law@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=rth@redhat.com \
--cc=segher@kernel.crashing.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).