From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 42667 invoked by alias); 11 May 2015 17:23:51 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 42603 invoked by uid 89); 11 May 2015 17:23:50 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Mon, 11 May 2015 17:23:49 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t4BHNm3a020092 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Mon, 11 May 2015 13:23:48 -0400 Received: from localhost.localdomain (ovpn-113-21.phx2.redhat.com [10.3.113.21]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t4BHNlkN015344; Mon, 11 May 2015 13:23:47 -0400 Message-ID: <5550E5A3.60305@redhat.com> Date: Mon, 11 May 2015 17:23:00 -0000 From: Jeff Law User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Segher Boessenkool , gcc-patches@gcc.gnu.org CC: rth@redhat.com Subject: Re: [PATCH] combine: Don't create (set (reg:CC) (compare (reg:CC) (const0))) References: In-Reply-To: Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2015-05/txt/msg00975.txt.bz2 On 05/11/2015 07:13 AM, Segher Boessenkool wrote: > There already was code to just use the original reg:CC, but it was > positioned incorrectly: if the original code (that this RTL is > simplified from) did not already start with a COMPARE (or not in > the right mode), it didn't trigger. But it is valid in that case > as well. > > This then allows merging the other two arms of this conditional; > do so. > > Bootstrapped and regression tested on powerpc64-linux and x86_64-linux; > no regressions. Also built toolchains and Linux kernels for every > arch where that works; no new failures on that. > > Any objections? > > > Segher > > > 2015-05-11 Segher Boessenkool > > * combine.c (simplify_set): When generating a CC set, if the > source already is in the correct mode, do not wrap it in a > compare. Simplify the rest of that code. Seems reasonable. Might not hurt to do a little testing on a cc0 target though. jeff