public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Jason Merrill <jason@redhat.com>
To: "Manuel López-Ibáñez" <lopezibanez@gmail.com>,
	"Patrick Palka" <"patrick@parcs.ath.cx"@redhat.com>,
	gcc-patches@gcc.gnu.org
Subject: Re: [PATCH] Fix memory leak in C++ pretty printer
Date: Mon, 11 May 2015 18:01:00 -0000	[thread overview]
Message-ID: <5550EE77.5060208@redhat.com> (raw)
In-Reply-To: <5550ED88.5040103@redhat.com>

On 05/11/2015 12:57 PM, Jason Merrill wrote:
> On 05/11/2015 08:03 AM, Manuel López-Ibáñez wrote:
>> My preference would be to replace the static with a pointer and
>> placement-new with proper new and delete

Actually, on second thought, there really doesn't seem to be a need for 
that.  The patch should be OK; if it doesn't work I'd like to know why. 
  I think the existing pattern is just a holdover from the C days.

Jason


  reply	other threads:[~2015-05-11 18:01 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-11  1:34 Patrick Palka
2015-05-11 13:04 ` Manuel López-Ibáñez
2015-05-11 17:57   ` Jason Merrill
2015-05-11 18:01     ` Jason Merrill [this message]
2015-05-20 14:58       ` Jason Merrill
2015-05-11 13:30 ` Manuel López-Ibáñez

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5550EE77.5060208@redhat.com \
    --to=jason@redhat.com \
    --cc="patrick@parcs.ath.cx"@redhat.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=lopezibanez@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).