From: Jeff Law <law@redhat.com>
To: sellcey@imgtec.com, Segher Boessenkool <segher@kernel.crashing.org>
Cc: "Kumar, Venkataramanan" <Venkataramanan.Kumar@amd.com>,
"gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>,
"maxim.kuvyrkov@linaro.org" <maxim.kuvyrkov@linaro.org>,
Matthew Fortune <Matthew.Fortune@imgtec.com>,
clm <clm@codesourcery.com>,
John David Anglin <dave@hiauly1.hia.nrc.ca>
Subject: Re: [RFC]: Remove Mem/address type assumption in combiner
Date: Mon, 11 May 2015 19:46:00 -0000 [thread overview]
Message-ID: <555106F9.1020408@redhat.com> (raw)
In-Reply-To: <1431373475.14613.212.camel@ubuntu-sellcey>
On 05/11/2015 01:44 PM, Steve Ellcey wrote:
> On Mon, 2015-05-11 at 13:22 -0500, Segher Boessenkool wrote:
>> Hi Steve,
>>
>> On Mon, May 11, 2015 at 10:50:02AM -0700, Steve Ellcey wrote:
>>> This patch broke a number of MIPS tests, specifically mips32r6 tests
>>> that look for the lsa instruction (load scaled address) which shifts one
>>> register and then adds it to a second register. I am not sure if this
>>> needs to be addressed in combine.c or if we need to add a peephole
>>> optimization to mips.md to handle the new instruction sequence. What do
>>> you think? Is the change here what you would expect to see from your
>>> patch?
>>
>> Yes, this is as expected. AFAICS the only change you need in the
>> MIPS backend is to change the "<GPR:d>lsa" pattern to match a shift
>> instead of a mult (and change the "const_immlsa_operand" predicate
>> to just match 1..4 instead of the powers).
>>
>>
>> Segher
>
> Hm, I thought it was going to be more complicated than that, but it
> seems to be working. I will do a complete test run and then submit a
> patch.
Yea, it really should be that easy.
I'm pretty sure the sh[123]add insns in the PA need to be updated in a
similar manner.
jeff
next prev parent reply other threads:[~2015-05-11 19:46 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-29 9:29 Kumar, Venkataramanan
2015-04-29 17:38 ` Segher Boessenkool
2015-04-29 19:23 ` Jeff Law
2015-05-01 15:18 ` Segher Boessenkool
2015-05-05 16:14 ` Kumar, Venkataramanan
2015-05-05 17:15 ` Segher Boessenkool
2015-05-07 11:01 ` Kumar, Venkataramanan
2015-05-11 17:50 ` Steve Ellcey
2015-05-11 18:27 ` Segher Boessenkool
2015-05-11 19:44 ` Steve Ellcey
2015-05-11 19:46 ` Jeff Law [this message]
2015-05-11 19:46 ` Jeff Law
2015-05-11 20:17 ` Matthew Fortune
2015-05-11 20:30 ` Segher Boessenkool
2015-05-11 20:54 ` Matthew Fortune
2015-05-12 6:43 ` Kumar, Venkataramanan
2015-05-12 16:57 ` Steve Ellcey
2015-05-12 22:02 ` Moore, Catherine
2015-05-16 6:09 ` Hans-Peter Nilsson
2015-05-16 14:36 ` Segher Boessenkool
2015-05-16 16:43 ` Hans-Peter Nilsson
2015-05-16 17:40 ` Segher Boessenkool
2015-05-17 8:53 ` Hans-Peter Nilsson
2015-05-17 13:32 ` Segher Boessenkool
2015-05-17 13:48 ` Hans-Peter Nilsson
2015-05-19 17:30 ` Jeff Law
2015-04-29 19:22 ` Jeff Law
2015-04-29 19:31 ` Jeff Law
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=555106F9.1020408@redhat.com \
--to=law@redhat.com \
--cc=Matthew.Fortune@imgtec.com \
--cc=Venkataramanan.Kumar@amd.com \
--cc=clm@codesourcery.com \
--cc=dave@hiauly1.hia.nrc.ca \
--cc=gcc-patches@gcc.gnu.org \
--cc=maxim.kuvyrkov@linaro.org \
--cc=segher@kernel.crashing.org \
--cc=sellcey@imgtec.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).