From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22098 invoked by alias); 11 May 2015 21:16:02 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 22088 invoked by uid 89); 11 May 2015 21:16:02 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Mon, 11 May 2015 21:16:01 +0000 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t4BLFwoG020353 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Mon, 11 May 2015 17:15:59 -0400 Received: from localhost.localdomain (ovpn-113-21.phx2.redhat.com [10.3.113.21]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t4BLFvKJ012632; Mon, 11 May 2015 17:15:58 -0400 Message-ID: <55511C0D.8020607@redhat.com> Date: Mon, 11 May 2015 21:16:00 -0000 From: Jeff Law User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Segher Boessenkool CC: gcc-patches@gcc.gnu.org, rth@redhat.com Subject: Re: [PATCH] combine: Don't create (set (reg:CC) (compare (reg:CC) (const0))) References: <5550E5A3.60305@redhat.com> <20150511211148.GL2521@gate.crashing.org> In-Reply-To: <20150511211148.GL2521@gate.crashing.org> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2015-05/txt/msg01017.txt.bz2 On 05/11/2015 03:11 PM, Segher Boessenkool wrote: > On Mon, May 11, 2015 at 11:23:47AM -0600, Jeff Law wrote: >>> * combine.c (simplify_set): When generating a CC set, if the >>> source already is in the correct mode, do not wrap it in a >>> compare. Simplify the rest of that code. >> Seems reasonable. Might not hurt to do a little testing on a cc0 target >> though. > > I tested on mn10300, cris, and m68k. On m68k it triggers while > building libgcc (for 040). I verified the transform is correct. Seems reasonable to me. > > I don't have a setup to actually bootstrap or regression check > any cc0 target. A recurring theme :-( Understood. As I mentioned in IRC and in another thread, it may be useful to set up an aranym instance for m68k bootstrap testing in the compile farm. For other targets, building foo-elf in a single tree build with binutils, newlib and the simulator, then running the gcc testsuite with the simulator is often a good alternative. Probably wise to run through this once or twice just to get familiar with it, then pull it out when really needed ;) jeff