From: Jason Merrill <jason@redhat.com>
To: Jan Hubicka <hubicka@ucw.cz>
Cc: gcc-patches@gcc.gnu.org
Subject: Re: False ODR violation positives on anonymous namespace types
Date: Mon, 11 May 2015 21:21:00 -0000 [thread overview]
Message-ID: <55511D40.1010808@redhat.com> (raw)
In-Reply-To: <20150511180509.GB22960@kam.mff.cuni.cz>
On 05/11/2015 01:05 PM, Jan Hubicka wrote:
>> On 05/11/2015 12:46 PM, Jan Hubicka wrote:
>>> Well, my main motivatoin to extend from RECORD_OR_UNION_TYPE_P was to handle
>>> enums. But other case I would like to deal with are integer types - i.e. preserve
>>> difference between char/signed char/unsigned char/short/int/long/wchar in cases
>>> where they structurally coincide.
>>
>> In what context? Won't you get that from comparing e.g. the field
>> types of two definitions of the same class?
>
> If one class define "int foo;" and other "long foo;" we currently do not complain
> about ODR on 32bit targets while I think we could.
We certainly should. But that's a problem because foo is subject to the
ODR. I don't see why you need to treat int as an ODR type to get
checking for foo.
Jason
next prev parent reply other threads:[~2015-05-11 21:21 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-11 14:28 Jan Hubicka
2015-05-11 17:16 ` Jason Merrill
2015-05-11 17:46 ` Jan Hubicka
2015-05-11 17:54 ` Jason Merrill
2015-05-11 18:05 ` Jan Hubicka
2015-05-11 21:21 ` Jason Merrill [this message]
2015-05-11 21:52 ` Jan Hubicka
2015-05-12 13:51 ` Jason Merrill
2015-05-12 14:13 ` Jan Hubicka
2015-05-12 14:54 ` Jan Hubicka
2015-05-12 16:07 ` Jason Merrill
2015-05-12 16:27 ` Jan Hubicka
2015-05-12 18:40 ` Jan Hubicka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55511D40.1010808@redhat.com \
--to=jason@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=hubicka@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).