From: Sandra Loosemore <sandra@codesourcery.com>
To: Jan Hubicka <hubicka@ucw.cz>
Cc: <gcc-patches@gcc.gnu.org>
Subject: Re: Work around PR65873
Date: Wed, 13 May 2015 20:12:00 -0000 [thread overview]
Message-ID: <5553ADF3.6000204@codesourcery.com> (raw)
In-Reply-To: <20150512221234.GA54352@kam.mff.cuni.cz>
On 05/12/2015 04:12 PM, Jan Hubicka wrote:
>
> Hi,
> this patch works around PR where we refuse to inline always_inline memcpy
> into function with explicit Ofast optimization attribute. This is because
> we think we can not promote -fno-fast-math code to -fast-math code.
> This is of course safe for memcpy because it contains to fast-math code,
> but we don't really do the analysis for each of the flags we check.
>
> Earlier compilers was happily producing wrong code here and it seems practical
> to do that on GCC 5 to deal with common falout. I will implement the more
> fine grained check incrementally.
>
> Bootstrapped/regtested x86_64-linux. Will commit it to mainline shortly and
> to release branch later this week.
>
> PR ipa/65873
> * ipa-inline.c (can_inline_edge_p): Allow early inlining of always
> inlines across optimization boundary.
> * testsuite/gcc.c-torture/compile/pr65873.c: New testcase.
> Index: ipa-inline.c
> ===================================================================
> --- ipa-inline.c (revision 223093)
> +++ ipa-inline.c (working copy)
> @@ -427,46 +427,55 @@ can_inline_edge_p (struct cgraph_edge *e
> && lookup_attribute ("always_inline",
> DECL_ATTRIBUTES (callee->decl)));
>
I'm having problems parsing the following comment block:
> + /* Until GCC 4.9 we did not check the semantics alterning flags
"alterning"?
> + bellow and inline across optimization boundry.
s/bellow/below/g
s/boundry/boundary/
> + Enabling checks bellow breaks several packages by refusing
> + to inline library always_inline functions. See PR65873.
> + Disable the check for early inlining for now until better solution
> + is found. */
> + if (always_inline && early)
> + ;
-Sandra
next prev parent reply other threads:[~2015-05-13 20:04 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-12 22:13 Jan Hubicka
2015-05-13 13:13 ` Richard Biener
2015-05-13 14:17 ` Jan Hubicka
2015-05-13 20:12 ` Sandra Loosemore [this message]
2015-05-17 18:23 ` Jan Hubicka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5553ADF3.6000204@codesourcery.com \
--to=sandra@codesourcery.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=hubicka@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).