From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg1-x531.google.com (mail-pg1-x531.google.com [IPv6:2607:f8b0:4864:20::531]) by sourceware.org (Postfix) with ESMTPS id 063883857C51 for ; Wed, 21 Dec 2022 14:56:44 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 063883857C51 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pg1-x531.google.com with SMTP id r18so10533405pgr.12 for ; Wed, 21 Dec 2022 06:56:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=mrDkCjBn3V40Yx6jLYAl8TyCii1k+msA6AirC1U6YfU=; b=Nzx1Z0t9q/sQfIro+Ly6/vmgiyU7KojocKzdN99yHq3hD+6v2qXjd/0UEjLKZEZOEI ktFG0604y3yBCPejuUeuXhNskua7wU6KOqtrudGS/CJ0uzif+SIWiKdORLmdhJB4yj92 cUMfSbViYx/UHFnk8sCGDtIdFpcRC/rotbX2XPPmtac0h564ZrOgzVcMeqtErWO4ygGf uwAJWG+6l/d8WnmzGgqnHa34sPuTOIt9EzJgp97wgtJBaG/9wDPcoX4EvIea9JjQeKXk hcvAQg7HSERYiidNnjCWXQU0B8DSETKOaRm6PbZk5KioSrur0oq79Cts2jy3vRgzeOT5 tutg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=mrDkCjBn3V40Yx6jLYAl8TyCii1k+msA6AirC1U6YfU=; b=H9NkzLeVMFUTia5xJmaOa4/q87SNLgbFD+FMt+AzY7sSNcLGudojXpO+zUPEa72M9d bR9NxQMdO2+bs8tWyz/pIc4yjiwXyxKrFv+1h/nnz15pYD007soO475I7nBFwug15Xpi 6QoA75lA74NGejzQuyEbY8JiqdCw9Segh1WHPRRlBpWWm80dpO582mFMSYQ3WM8FJn2U EqO3YTDbUY/QL93mHyklQCrk78Hge/yO0Mm8xvDF7JkjuoCckpUzWnXXzpn+ApL3e93n G1Ikrs8T6qrlsZBxRCu8POm5Qr9ydBSzGmPZJUN/QvKyMn/n/3TD81mocpadaAWm7VvV G3pQ== X-Gm-Message-State: AFqh2kpZrHAQ+WfwyBM8XQEmbqzOF6g1BBO6tVOGLQovGEkefVwy3Gu1 wEfV6lDKy66vMCjNtAhnuaQ= X-Google-Smtp-Source: AMrXdXswroJ+A5xIFyWdJhZgfzYGu4dN0TL9522mIM9XSyJRbJOc/eYi8XOI5dhBhCxfoalk5wcjmQ== X-Received: by 2002:a62:15d0:0:b0:56d:370f:1dc3 with SMTP id 199-20020a6215d0000000b0056d370f1dc3mr17418898pfv.9.1671634602753; Wed, 21 Dec 2022 06:56:42 -0800 (PST) Received: from ?IPV6:2601:681:8600:13d0::f0a? ([2601:681:8600:13d0::f0a]) by smtp.gmail.com with ESMTPSA id x4-20020aa79a44000000b005769cee6735sm10722920pfj.43.2022.12.21.06.56.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 21 Dec 2022 06:56:42 -0800 (PST) Message-ID: <5553e750-bc8c-497f-fa84-a31eed258f53@gmail.com> Date: Wed, 21 Dec 2022 07:56:40 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.1 Subject: Re: [PATCHv2] Use toplevel configure for GMP and MPFR for gdb Content-Language: en-US To: Andrew Pinski , Tom Tromey Cc: apinski--- via Gdb-patches , binutils@sourceware.org, gcc-patches@gcc.gnu.org, apinski@marvell.com References: <1668107159-16961-1-git-send-email-apinski@marvell.com> <877cyllx53.fsf@tromey.com> From: Jeff Law In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 12/20/22 20:45, Andrew Pinski wrote: > On Tue, Dec 20, 2022 at 10:59 AM Tom Tromey wrote: >> >>>>>>> "Andrew" == apinski--- via Gdb-patches writes: >> >> Andrew> From: Andrew Pinski >> Andrew> This patch uses the toplevel configure parts for GMP/MPFR for >> Andrew> gdb. The only thing is that gdb now requires MPFR for building. >> Andrew> Before it was a recommended but not required library. >> Andrew> Also this allows building of GMP and MPFR with the toplevel >> Andrew> directory just like how it is done for GCC. >> Andrew> We now error out in the toplevel configure of the version >> Andrew> of GMP and MPFR that is wrong. >> >> Andrew> OK after GDB 13 branches? Build gdb 3 ways: >> Andrew> with GMP and MPFR in the toplevel (static library used at that point for both) >> Andrew> With only MPFR in the toplevel (GMP distro library used and MPFR built from source) >> Andrew> With neither GMP and MPFR in the toplevel (distro libraries used) >> >> I think it's fine to move forward with this now. >> Thank you again for doing this. > > Just to double check this is an approval? > > Jeff, > Just to double check this is still ok for gcc repo even if we are in stage 3? Yea, it was submitted prior to stage1 closing and approved for GCC once the GDB folks signed off. jeff