public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Jeff Law <law@redhat.com>
To: Iain Buclaw <ibuclaw@gdcproject.org>,
	       gcc-patches <gcc-patches@gcc.gnu.org>,
	       Ian Lance Taylor <iant@google.com>
Subject: Re: [PATCH 3/7] [D] libiberty: Include type modifiers in demangled function symbols
Date: Thu, 14 May 2015 13:09:00 -0000	[thread overview]
Message-ID: <55549DE2.6010305@redhat.com> (raw)
In-Reply-To: <CABOHX+fZ5kVbUv_PPShK44Dm94yy9aE699UTdndJdrNHB6Xvqg@mail.gmail.com>

On 05/13/2015 02:51 AM, Iain Buclaw wrote:
> Like C++ const and volatile, in D mangled symbols can exist modifiers
> that represent the const, immutable, inout and shared-ness of the
> 'this' parameter.
>
> This information should be written out in the demangled symbol to show
> that each variant has a unique identity.
>
> ---
> libiberty/ChangeLog:
>
> 2015-05-13 Iain Buclaw  <ibuclaw@gdcproject.org>
>      * d-demangle.c (dlang_type_modifiers): New function.
>      (dlang_type_modifier_p): New function.
>      (dlang_call_convention_p): Ignore any kind of type modifier.
>      (dlang_type): Handle and emit the type modifier after delegate types.
>      (dlang_parse_symbol): Handle and emit the type modifier after the symbol.
>      * testsuite/d-demangle-expected: Add coverage tests for all valid
>      usages of function symbols with type modifiers.
OK.
jeff

      parent reply	other threads:[~2015-05-14 13:06 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-13  8:51 Iain Buclaw
2015-05-13 20:36 ` Iain Buclaw
2015-05-13 20:52   ` Iain Buclaw
2015-05-14 13:09 ` Jeff Law [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55549DE2.6010305@redhat.com \
    --to=law@redhat.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=iant@google.com \
    --cc=ibuclaw@gdcproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).