From: Jeff Law <law@redhat.com>
To: Marc Glisse <marc.glisse@inria.fr>
Cc: gcc-patches@gcc.gnu.org
Subject: Re: [RFA] More type narrowing in match.pd V2
Date: Thu, 14 May 2015 14:47:00 -0000 [thread overview]
Message-ID: <5554B11E.8090705@redhat.com> (raw)
In-Reply-To: <alpine.DEB.2.02.1505141554100.30908@stedding.saclay.inria.fr>
On 05/14/2015 08:04 AM, Marc Glisse wrote:
> On Fri, 1 May 2015, Jeff Law wrote:
>
>> Slight refactoring of the condition by using types_match as suggested
>> by Richi. I also applied the new types_match to 2 other patterns in
>> match.pd where it seemed clearly appropriate.
>
> I would like to propose this small tweak (regtested ok). If we had a
> different type for trees and types, this would be overloading the
> function. We already do this in a few places, and I find the resulting
> shorter code more readable.
>
> 2015-05-14 Marc Glisse <marc.glisse@inria.fr>
>
> * generic-match-head.c (types_match): Handle non-types.
> * gimple-match-head.c (types_match): Likewise.
> * match.pd: Remove unnecessary TREE_TYPE for types_match.
Update the comment for types_match and this is fine.
jeff
next prev parent reply other threads:[~2015-05-14 14:28 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-02 0:36 Jeff Law
2015-05-02 21:18 ` Bernhard Reutner-Fischer
2015-05-04 17:05 ` Jeff Law
2015-05-04 9:02 ` Richard Biener
2015-05-04 19:59 ` H.J. Lu
2015-05-14 14:21 ` Marc Glisse
2015-05-14 14:47 ` Jeff Law [this message]
2015-05-18 9:22 ` Richard Biener
2015-05-18 9:48 ` Richard Biener
2015-05-18 12:40 ` Marc Glisse
2015-05-18 12:53 ` Richard Biener
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5554B11E.8090705@redhat.com \
--to=law@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=marc.glisse@inria.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).