From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 83600 invoked by alias); 17 May 2015 20:21:27 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 83580 invoked by uid 89); 17 May 2015 20:21:26 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.6 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-Spam-User: qpsmtpd, 2 recipients X-HELO: mail-wg0-f48.google.com Received: from mail-wg0-f48.google.com (HELO mail-wg0-f48.google.com) (74.125.82.48) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Sun, 17 May 2015 20:21:25 +0000 Received: by wgjc11 with SMTP id c11so4427263wgj.0; Sun, 17 May 2015 13:21:22 -0700 (PDT) X-Received: by 10.194.61.171 with SMTP id q11mr32554996wjr.110.1431894081973; Sun, 17 May 2015 13:21:21 -0700 (PDT) Received: from [192.168.0.22] (arf62-1-82-237-250-248.fbx.proxad.net. [82.237.250.248]) by mx.google.com with ESMTPSA id v20sm13460837wjr.49.2015.05.17.13.21.20 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 17 May 2015 13:21:21 -0700 (PDT) Message-ID: <5558F840.3070306@gmail.com> Date: Sun, 17 May 2015 20:42:00 -0000 From: =?windows-1252?Q?Fran=E7ois_Dumont?= User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: Jonathan Wakely CC: libstdc++@gcc.gnu.org, gcc-patches@gcc.gnu.org Subject: Re: [patch] libstdc++/66055 add missing constructors to unordered containers References: <20150514134731.GS30202@redhat.com> <55571056.2090807@gmail.com> <20150516193210.GW30202@redhat.com> In-Reply-To: <20150516193210.GW30202@redhat.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 8bit X-SW-Source: 2015-05/txt/msg01514.txt.bz2 Ok, I just commit fixing some other lines length except those having a long hyperlink, I didn't want to break those. François On 16/05/2015 21:32, Jonathan Wakely wrote: > On 16/05/15 11:39 +0200, François Dumont wrote: >> On 14/05/2015 15:47, Jonathan Wakely wrote: >>> Reported by Nathan and fixed by his patch. I added the tests. >>> >>> Tested powerpc64le-linux, committed to trunk. This should be >>> backported too. >> >> While backporting to debug and profile mode I noticed that those >> constructors were not the only missing ones. So here is a patch to >> complete them with debug and profile modes. > > Great, thanks. > >> @@ -233,6 +222,41 @@ _GLIBCXX_BEGIN_NAMESPACE_CONTAINER >> : _M_h(__l, __n, __hf, __eql, __a) >> { } >> >> + unordered_map(size_type __n, const allocator_type& __a) >> + : unordered_map(__n, hasher(), key_equal(), __a) >> + { } >> + >> + unordered_map(size_type __n, const hasher& __hf, >> + const allocator_type& __a) >> + : unordered_map(__n, __hf, key_equal(), __a) >> + { } >> + >> + template >> + unordered_map(_InputIterator __first, _InputIterator __last, >> + size_type __n, >> + const allocator_type& __a) >> + : unordered_map(__first, __last, __n, hasher(), key_equal(), __a) > > The indentation is inconsistent here, the ctor-initializer-list is > indented further than necessary > >> @@ -891,7 +941,7 @@ _GLIBCXX_BEGIN_NAMESPACE_CONTAINER >> * in the initializer list @a __l. >> * >> * Note that the assignment completely changes the >> %unordered_multiset >> - * and that the resulting %unordered_set's size is the same >> as the number >> + * and that the resulting %unordered_multiset's size is the >> same as the number >> * of elements assigned. Old data may be lost. > > Please reformat this to stay below 80 columns. > > OK with those two tiny adjustments, thanks! > >