Re: [PATCH, ARM] attribute target (thumb,arm) [4/6] respin (4th)

[Christian Bruel <christian.bruel@st.com>]

Hi Ramana,

On 05/08/2015 10:31 AM, Ramana Radhakrishnan wrote:
>
> I'm still playing with the code, so this is a partial review.
>
> We should prevent inlining of ARM state functions into functions we know
> will be T16 if !TARGET_SOFT_FLOAT on the grounds that the architecture
> doesn't have floating point instruction encodings in the T16 ISA
> (Thumb1). We'll just cause internal compiler errors if we allow this.
>

I tried to forge a bit with this situation, but I couldn't generate such 
inconsistencies, as the situation is rejected with a :
"sorry, unimplemented: Thumb-1 hard-float VFP ABI"
when using -march=armv6 -mthumb -mhard-float (would that match with T16 
&& !TARGET_SOFT_FLOAT)

Do you have the example producing an ICE ? That would be interesting to 
add it in the testsuite.

by the way, I think the error message should be changed from

"sorry, unimplemented: Thumb-1 hard-float VFP ABI"

to a user error:

"Can't use Thumb-1 hard-float VFP ABI"

Christian